Issue 965943002: Fixing a bug in the QUIC prober where if we received a GOAWAY before

Issue 965943002: Fixing a bug in the QUIC prober where if we received a GOAWAY before (Closed)

Created:
5 years, 9 months ago by ramant (doing other things)

Modified:
5 years, 9 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@Remove_dead_method_QuicUnackedPacketMap_RestoreInFlight_86690324

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fixing a bug in the QUIC prober where if we received a GOAWAY before stream creation it would result in a crash. I verified that given our improper client, the prober would crash as-was, and would fail cleanly with the nullptr check but the client not ignoring goaways. Test changes and quic server changes. Merge internal change: 86703503 R=rch@chromium.org

Patch Set 1 #

Total comments: 2

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+126 lines, -0 lines)			Patch
M	net/net.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	net/quic/quic_server.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	net/tools/quic/quic_server.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	net/tools/quic/test_tools/quic_test_server.h	View	1 chunk	+51 lines, -0 lines	2 comments	Download
A	net/tools/quic/test_tools/quic_test_server.cc	View	1 chunk	+69 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

lgtm https://codereview.chromium.org/965943002/diff/1/net/tools/quic/test_tools/quic_test_server.h File net/tools/quic/test_tools/quic_test_server.h (right): https://codereview.chromium.org/965943002/diff/1/net/tools/quic/test_tools/quic_test_server.h#newcode5 net/tools/quic/test_tools/quic_test_server.h:5: #ifndef NET_TOOLS_QUIC_TEST_TOOLS_QUIC_TEST_SERVER_H_ Do we need this file? or ...

5 years, 9 months ago (2015-02-28 00:29:48 UTC) #2

ramant (doing other things)

https://codereview.chromium.org/965943002/diff/1/net/tools/quic/test_tools/quic_test_server.h File net/tools/quic/test_tools/quic_test_server.h (right): https://codereview.chromium.org/965943002/diff/1/net/tools/quic/test_tools/quic_test_server.h#newcode5 net/tools/quic/test_tools/quic_test_server.h:5: #ifndef NET_TOOLS_QUIC_TEST_TOOLS_QUIC_TEST_SERVER_H_ On 2015/02/28 00:29:48, Ryan Hamilton wrote: > ...

5 years, 9 months ago (2015-02-28 01:06:01 UTC) #3

ramant (doing other things)

On 2015/02/28 01:06:01, ramant wrote: > https://codereview.chromium.org/965943002/diff/1/net/tools/quic/test_tools/quic_test_server.h > File net/tools/quic/test_tools/quic_test_server.h (right): > > https://codereview.chromium.org/965943002/diff/1/net/tools/quic/test_tools/quic_test_server.h#newcode5 > ...

5 years, 9 months ago (2015-03-02 19:30:24 UTC) #4

Expand Messages | Collapse Messages