Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 965933002: Address NewApi and other Android lint warnings in src/chrome. (Closed)

Created:
5 years, 9 months ago by newt (away)
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Address NewApi and other Android lint warnings in src/chrome. BUG=266140 R=aurimas@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/47fb4821713cf85fce53c5bae575343e97041681

Patch Set 1 #

Patch Set 2 : rebase #

Messages

Total messages: 9 (3 generated)
newt (away)
PTAL
5 years, 9 months ago (2015-02-28 00:58:19 UTC) #2
aurimas (slooooooooow)
lgtm
5 years, 9 months ago (2015-02-28 01:00:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/965933002/1
5 years, 9 months ago (2015-02-28 01:04:40 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/63189)
5 years, 9 months ago (2015-02-28 01:59:55 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/47fb4821713cf85fce53c5bae575343e97041681 Cr-Commit-Position: refs/heads/master@{#318735}
5 years, 9 months ago (2015-03-02 19:26:13 UTC) #8
newt (away)
5 years, 9 months ago (2015-03-02 19:26:23 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
47fb4821713cf85fce53c5bae575343e97041681 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698