Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 965823002: Contribution of PowerPC port (continuation of 422063005) - currency (Closed)

Created:
5 years, 9 months ago by michael_dawson
Modified:
5 years, 9 months ago
Reviewers:
Sven Panne, danno
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Contribution of PowerPC port (continuation of 422063005) - currency Contribution of PowerPC port (continuation of 422063005, 817143002, 866843003, and 901083004. This patch updates the ppc directories to make them current with changes in common code, removes the optimization to use the ool constant pool, and excludes tests that don't pass under the ppc simulator given a 240s timeout. Subsequent patches will cover: - remaining optimizations for PPC - remaining AIX changes not resolved by 4.8 compiler (4.8 is only recently available for AIX) - incremental updates required to ppc directories due to platform specific changes made in google repos while we complete the above steps. modified: src/compiler/ppc/code-generator-ppc.cc modified: src/ic/ppc/handler-compiler-ppc.cc modified: src/ppc/assembler-ppc-inl.h modified: src/ppc/assembler-ppc.cc modified: src/ppc/assembler-ppc.h modified: src/ppc/builtins-ppc.cc modified: src/ppc/code-stubs-ppc.cc modified: src/ppc/debug-ppc.cc modified: src/ppc/deoptimizer-ppc.cc modified: src/ppc/frames-ppc.cc modified: src/ppc/frames-ppc.h modified: src/ppc/full-codegen-ppc.cc modified: src/ppc/lithium-codegen-ppc.cc modified: src/ppc/lithium-ppc.cc modified: src/ppc/lithium-ppc.h modified: src/ppc/macro-assembler-ppc.cc modified: src/ppc/macro-assembler-ppc.h modified: test/cctest/cctest.status modified: test/mjsunit/mjsunit.status R=danno@chromium.org, svenpanne@chromium.org BUG= Committed: https://crrev.com/a3465838bc8b94676bd1bb6604c078008ab24632 Cr-Commit-Position: refs/heads/master@{#26951}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -815 lines) Patch
M src/compiler/ppc/code-generator-ppc.cc View 13 chunks +17 lines, -24 lines 0 comments Download
M src/ic/ppc/handler-compiler-ppc.cc View 4 chunks +14 lines, -5 lines 0 comments Download
M src/ppc/assembler-ppc.h View 16 chunks +16 lines, -146 lines 0 comments Download
M src/ppc/assembler-ppc.cc View 15 chunks +22 lines, -268 lines 0 comments Download
M src/ppc/assembler-ppc-inl.h View 6 chunks +7 lines, -89 lines 0 comments Download
M src/ppc/builtins-ppc.cc View 15 chunks +17 lines, -29 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 9 chunks +10 lines, -19 lines 0 comments Download
M src/ppc/debug-ppc.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/ppc/deoptimizer-ppc.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/ppc/frames-ppc.h View 2 chunks +0 lines, -12 lines 0 comments Download
M src/ppc/frames-ppc.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M src/ppc/full-codegen-ppc.cc View 4 chunks +3 lines, -12 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 11 chunks +25 lines, -24 lines 0 comments Download
M src/ppc/lithium-ppc.h View 1 chunk +6 lines, -2 lines 0 comments Download
M src/ppc/lithium-ppc.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/ppc/macro-assembler-ppc.h View 4 chunks +10 lines, -11 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 15 chunks +27 lines, -149 lines 0 comments Download
M test/cctest/cctest.status View 1 chunk +15 lines, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
michael_dawson
Unfortunately there are new platform specific changes since the base we started on, but this ...
5 years, 9 months ago (2015-02-27 17:54:59 UTC) #1
Sven Panne
lgtm
5 years, 9 months ago (2015-03-02 12:35:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/965823002/1
5 years, 9 months ago (2015-03-02 12:35:53 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_TIMED_OUT, no build URL) v8_linux_dbg on ...
5 years, 9 months ago (2015-03-02 14:28:53 UTC) #6
michael_dawson
On 2015/03/02 14:28:53, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 9 months ago (2015-03-02 16:23:57 UTC) #7
michael_dawson
On 2015/03/02 16:23:57, michael_dawson wrote: > On 2015/03/02 14:28:53, I haz the power (commit-bot) wrote: ...
5 years, 9 months ago (2015-03-02 23:14:37 UTC) #8
Sven Panne
On 2015/03/02 23:14:37, michael_dawson wrote: > I see the trybots now report as all green, ...
5 years, 9 months ago (2015-03-03 07:04:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/965823002/1
5 years, 9 months ago (2015-03-03 07:04:21 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-03 07:04:50 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 07:05:13 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a3465838bc8b94676bd1bb6604c078008ab24632
Cr-Commit-Position: refs/heads/master@{#26951}

Powered by Google App Engine
This is Rietveld 408576698