Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 965813003: Removed the "Swipe to close in overview" feature. (Closed)

Created:
5 years, 9 months ago by bruthig
Modified:
5 years, 9 months ago
Reviewers:
flackr
CC:
chromium-reviews, tdanderson+overview_chromium.org, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed the "Swipe to close in overview" feature. BUG=393668 Committed: https://crrev.com/f64ae1722fbf21c6024abc2720507e051d1fa7ad Cr-Commit-Position: refs/heads/master@{#318706}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -433 lines) Patch
M ash/ash_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/ash_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/wm/overview/overview_animation_type.h View 2 chunks +1 line, -8 lines 0 comments Download
M ash/wm/overview/scoped_overview_animation_settings.cc View 4 chunks +0 lines, -17 lines 0 comments Download
M ash/wm/overview/window_selector_controller.h View 2 chunks +0 lines, -5 lines 0 comments Download
M ash/wm/overview/window_selector_controller.cc View 2 chunks +1 line, -5 lines 0 comments Download
M ash/wm/overview/window_selector_item.h View 4 chunks +1 line, -23 lines 0 comments Download
M ash/wm/overview/window_selector_item.cc View 7 chunks +2 lines, -118 lines 0 comments Download
M ash/wm/overview/window_selector_unittest.cc View 4 chunks +0 lines, -238 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
bruthig
flackr@ can you please review all files?
5 years, 9 months ago (2015-02-27 19:46:14 UTC) #2
flackr
lgtm
5 years, 9 months ago (2015-02-28 15:28:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/965813003/1
5 years, 9 months ago (2015-02-28 15:54:30 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/878)
5 years, 9 months ago (2015-02-28 15:59:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/965813003/1
5 years, 9 months ago (2015-02-28 16:25:12 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/880)
5 years, 9 months ago (2015-02-28 16:30:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/965813003/1
5 years, 9 months ago (2015-03-02 15:11:33 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-02 16:13:34 UTC) #14
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 16:14:23 UTC) #15
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f64ae1722fbf21c6024abc2720507e051d1fa7ad
Cr-Commit-Position: refs/heads/master@{#318706}

Powered by Google App Engine
This is Rietveld 408576698