Print test that is being retried

Print test that is being retried

It's sometimes hard to tell which test is being retried because
tests are usually run in parallel among many devices. So just print the
name of test of device to make debugging easier.

BUG=

Committed: https://crrev.com/4fb936475e23d7acb7e286c08f8417b1803e4ba8
Cr-Commit-Position: refs/heads/master@{#318590}

[boliu, 2015-02-28 02:14:55]

boliu@chromium.org changed reviewers:
+ jbudorick@chromium.org

[boliu, 2015-02-28 02:14:56]

ptal

Note I don't write python very often. And I only tried this on instrumentation
tests

[jbudorick, 2015-02-28 02:26:52]

https://codereview.chromium.org/965803005/diff/1/build/android/pylib/base/tes...
File build/android/pylib/base/test_dispatcher.py (right):

https://codereview.chromium.org/965803005/diff/1/build/android/pylib/base/tes...
build/android/pylib/base/test_dispatcher.py:119: logging.warning('Will retry
test %s, try #%s.' % (repr(test.test),
This should be retry, not test.test. (test.test works with instrumentation
tests, but retry will work properly with gtests as well)

Also, since you're in here, could you pass the two format arguments as
additional arguments to logging.warning? i.e.

  logging.warning('Will retry test %s, try #%s.', retry, test.tries)

[boliu, 2015-02-28 02:37:56]

https://codereview.chromium.org/965803005/diff/1/build/android/pylib/base/tes...
File build/android/pylib/base/test_dispatcher.py (right):

https://codereview.chromium.org/965803005/diff/1/build/android/pylib/base/tes...
build/android/pylib/base/test_dispatcher.py:119: logging.warning('Will retry
test %s, try #%s.' % (repr(test.test),
On 2015/02/28 02:26:52, jbudorick wrote:
> This should be retry, not test.test. (test.test works with instrumentation
> tests, but retry will work properly with gtests as well)
> 
> Also, since you're in here, could you pass the two format arguments as
> additional arguments to logging.warning? i.e.
> 
>   logging.warning('Will retry test %s, try #%s.', retry, test.tries) 

Done.

[jbudorick, 2015-02-28 02:38:41]

lgtm

Thanks, I should've thought of this a while ago.

[boliu, 2015-02-28 02:46:50]

The CQ bit was checked by boliu@chromium.org

[commit-bot: I haz the power, 2015-02-28 02:47:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/965803005/40001

[commit-bot: I haz the power, 2015-02-28 03:46:03]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-28 03:46:45]

Patchset 3 (id:??) landed as
https://crrev.com/4fb936475e23d7acb7e286c08f8417b1803e4ba8
Cr-Commit-Position: refs/heads/master@{#318590}