Remove the overwrite parameter from PrefProvider::ReadContentSettingsFromPref

Remove the overwrite parameter from PrefProvider::ReadContentSettingsFromPref

The overwrite parameter determines whether the value_map_ member should be cleared.
The only time it is called with "false" is from the constructor at which point
value_map_ should be empty anyway. So we should be able just to remove this
parameter.

Committed: https://crrev.com/ef44b2744f9e2ab0e80c480c27faf0af162760d6
Cr-Commit-Position: refs/heads/master@{#318829}

[raymes, 2015-03-02 02:49:17]

raymes@chromium.org changed reviewers:
+ markusheintz@chromium.org, msramek@chromium.org

[msramek, 2015-03-02 09:46:49]

On 2015/03/02 02:49:17, raymes wrote:

LGTM. Looks like it's just some leftover.

[markusheintz_, 2015-03-02 10:06:01]

On 2015/03/02 09:46:49, msramek wrote:
> On 2015/03/02 02:49:17, raymes wrote:
> 
> LGTM. Looks like it's just some leftover.

Are these methods used anywhere? I would expect that you need to change the call
sites too.

[msramek, 2015-03-02 10:40:03]

On 2015/03/02 10:06:01, markusheintz_ wrote:
> On 2015/03/02 09:46:49, msramek wrote:
> > On 2015/03/02 02:49:17, raymes wrote:
> > 
> > LGTM. Looks like it's just some leftover.
> 
> Are these methods used anywhere? I would expect that you need to change the
call
> sites too.

Lines 99 and 494 in .cc are the only callsites, and those are changed
accordingly.

[markusheintz_, 2015-03-02 10:46:38]

On 2015/03/02 10:40:03, msramek wrote:
> On 2015/03/02 10:06:01, markusheintz_ wrote:
> > On 2015/03/02 09:46:49, msramek wrote:
> > > On 2015/03/02 02:49:17, raymes wrote:
> > > 
> > > LGTM. Looks like it's just some leftover.
> > 
> > Are these methods used anywhere? I would expect that you need to change the
> call
> > sites too.
> 
> Lines 99 and 494 in .cc are the only callsites, and those are changed
> accordingly.

LGTM

[raymes, 2015-03-03 01:35:43]

The CQ bit was checked by raymes@chromium.org

[commit-bot: I haz the power, 2015-03-03 01:36:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/965793003/1

[commit-bot: I haz the power, 2015-03-03 03:24:56]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-03-03 03:25:52]

Patchset 1 (id:??) landed as
https://crrev.com/ef44b2744f9e2ab0e80c480c27faf0af162760d6
Cr-Commit-Position: refs/heads/master@{#318829}