Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 965793002: Web MIDI: MIDI input messages may be lost or cause a crash on OS X (Closed)

Created:
5 years, 9 months ago by Takashi Toyoshima
Modified:
5 years, 9 months ago
Reviewers:
yhirano
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Web MIDI: MIDI input messages may be lost or cause a crash on OS X MIDIPacketList can contain multiple MIDIPacket, but MIDIPacket objects have different sizes depending on packet contents. So we should not refer to MIDIPackets via array index, but should use MIDIPacketNext that Core MIDI API provides to obtain the next object. As a result, previous code may refer invalid memory region if large MIDI messages are received at the same time. BUG=456780, 374560 Committed: https://crrev.com/3cb91369e4dfa935884c0cdbfd1b664b0fe2c026 Cr-Commit-Position: refs/heads/master@{#318653}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M media/midi/midi_manager_mac.cc View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Takashi Toyoshima
ptal
5 years, 9 months ago (2015-02-27 15:47:47 UTC) #2
yhirano
lgtm
5 years, 9 months ago (2015-03-02 05:35:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/965793002/1
5 years, 9 months ago (2015-03-02 06:07:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-02 06:39:00 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 06:39:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3cb91369e4dfa935884c0cdbfd1b664b0fe2c026
Cr-Commit-Position: refs/heads/master@{#318653}

Powered by Google App Engine
This is Rietveld 408576698