Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 965763002: Revert of Revert of Roll ASan/Win to LLVM r229860 (Closed)

Created:
5 years, 9 months ago by Timur Iskhodzhanov
Modified:
5 years, 9 months ago
Reviewers:
inferno
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Roll ASan/Win to LLVM r229860 (patchset #1 id:1 of https://codereview.chromium.org/953063003/) Reason for revert: It didn't help, see https://code.google.com/p/chromium/issues/detail?id=414136#c28 Original issue's description: > Revert of Roll ASan/Win to LLVM r229860 (patchset #1 id:1 of https://codereview.chromium.org/911323004/) > > Reason for revert: > Probable reason for Sanitizer CHECK failure in CHECK failed: "((curr_thread)) != (0)" (0x0, 0x0) > > BUG=414136, 459722 > > Original issue's description: > > Roll ASan/Win to LLVM r229860 > > > > This should fix > > BUG=459722 > > > > Please note I'm rolling this without waiting for the ASan/Win FYI bot to cycle > > (takes ~4 hours) to reduce the time it takes the LKGR ASan builder to turn green > > (assuming r229860 is most likely OK). If it isn't OK, we'll need to roll once > > again when we know the next stable LLVM revision. > > > > TBR=inferno@chromium.org > > NOTRY=true > > > > Committed: https://crrev.com/fea6440d7458b483d1e230be5e27a5a90e077a80 > > Cr-Commit-Position: refs/heads/master@{#317056} > > TBR=timurrrr@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/7e94fd20fcd956162a62d8e7b35b14f76deba495 > Cr-Commit-Position: refs/heads/master@{#317880} TBR=inferno@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=414136, 459722 Committed: https://crrev.com/cfc164bfa9c33012274456854c1907f5af8fd758 Cr-Commit-Position: refs/heads/master@{#318445}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/clang/scripts/update.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Timur Iskhodzhanov
Created Revert of Revert of Roll ASan/Win to LLVM r229860
5 years, 9 months ago (2015-02-27 14:18:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/965763002/1
5 years, 9 months ago (2015-02-27 14:18:48 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-02-27 14:19:48 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-02-27 14:20:14 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cfc164bfa9c33012274456854c1907f5af8fd758
Cr-Commit-Position: refs/heads/master@{#318445}

Powered by Google App Engine
This is Rietveld 408576698