Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/ic/mips/handler-compiler-mips.cc

Issue 965723002: Ensure we can reliably check the cell for validity of global property (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/ic.cc ('k') | src/ic/mips64/handler-compiler-mips64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_MIPS 7 #if V8_TARGET_ARCH_MIPS
8 8
9 #include "src/ic/call-optimization.h" 9 #include "src/ic/call-optimization.h"
10 #include "src/ic/handler-compiler.h" 10 #include "src/ic/handler-compiler.h"
(...skipping 469 matching lines...) Expand 10 before | Expand all | Expand 10 after
480 } 480 }
481 481
482 // Go to the next object in the prototype chain. 482 // Go to the next object in the prototype chain.
483 current = prototype; 483 current = prototype;
484 current_map = handle(current->map()); 484 current_map = handle(current->map());
485 } 485 }
486 486
487 // Log the check depth. 487 // Log the check depth.
488 LOG(isolate(), IntEvent("check-maps-depth", depth + 1)); 488 LOG(isolate(), IntEvent("check-maps-depth", depth + 1));
489 489
490 if (depth != 0 || check == CHECK_ALL_MAPS) { 490 if (!current_map->IsJSGlobalObjectMap() &&
491 (depth != 0 || check == CHECK_ALL_MAPS)) {
491 // Check the holder map. 492 // Check the holder map.
492 __ lw(scratch1, FieldMemOperand(reg, HeapObject::kMapOffset)); 493 __ lw(scratch1, FieldMemOperand(reg, HeapObject::kMapOffset));
493 Handle<WeakCell> cell = Map::WeakCellForMap(current_map); 494 Handle<WeakCell> cell = Map::WeakCellForMap(current_map);
494 __ GetWeakValue(scratch2, cell); 495 __ GetWeakValue(scratch2, cell);
495 __ Branch(miss, ne, scratch2, Operand(scratch1)); 496 __ Branch(miss, ne, scratch2, Operand(scratch1));
496 } 497 }
497 498
498 // Return the register containing the holder. 499 // Return the register containing the holder.
499 return reg; 500 return reg;
500 } 501 }
(...skipping 237 matching lines...) Expand 10 before | Expand all | Expand 10 after
738 // Return the generated code. 739 // Return the generated code.
739 return GetCode(kind(), Code::NORMAL, name); 740 return GetCode(kind(), Code::NORMAL, name);
740 } 741 }
741 742
742 743
743 #undef __ 744 #undef __
744 } 745 }
745 } // namespace v8::internal 746 } // namespace v8::internal
746 747
747 #endif // V8_TARGET_ARCH_MIPS 748 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/ic/ic.cc ('k') | src/ic/mips64/handler-compiler-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698