build/config/win/BUILD.gn - Issue 965713002: Handle unpatched VS xtree header

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/win/BUILD.gn

Issue 965713002: Handle unpatched VS xtree header (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/win/BUILD.gn

diff --git a/build/config/win/BUILD.gn b/build/config/win/BUILD.gn

index 201d45baf5b7f621c011462afbe9d0ba711fb1a8..95fc18f2b780bee9ec72e06b3b0667573e06f5b3 100644

--- a/build/config/win/BUILD.gn

+++ b/build/config/win/BUILD.gn

@@ -138,3 +138,14 @@ config("lean_and_mean") {

config("nominmax") {

defines = [ "NOMINMAX" ]

}

+# 4702 warning -----------------------------------------------------------------

+# VS xtree header file needs to be patched or 4702 (unreachable code warning)

+# is reported if _HAS_EXCEPTIONS=0. Disable the warning if xtree is not patched.

+config("msvs_xtree_unreachable_code") {

+ if (!msvs_xtree_patched) {

+ cflags = [ "/wd4702" ]

+ }