Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Side by Side Diff: build/config/win/BUILD.gn

Issue 965713002: Handle unpatched VS xtree header (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/win/visual_studio_version.gni") 5 import("//build/config/win/visual_studio_version.gni")
6 6
7 # Compiler setup for the Windows SDK. Applied to all targets. 7 # Compiler setup for the Windows SDK. Applied to all targets.
8 config("sdk") { 8 config("sdk") {
9 # The include path is the stuff returned by the script. 9 # The include path is the stuff returned by the script.
10 #include_dirs = msvc_config[0] TODO(brettw) make this work. 10 #include_dirs = msvc_config[0] TODO(brettw) make this work.
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 131
132 # Nominmax -------------------------------------------------------------------- 132 # Nominmax --------------------------------------------------------------------
133 133
134 # Some third party code defines NOMINMAX before including windows.h, which 134 # Some third party code defines NOMINMAX before including windows.h, which
135 # then causes warnings when it's been previously defined on the command line. 135 # then causes warnings when it's been previously defined on the command line.
136 # For such targets, this config can be removed. 136 # For such targets, this config can be removed.
137 137
138 config("nominmax") { 138 config("nominmax") {
139 defines = [ "NOMINMAX" ] 139 defines = [ "NOMINMAX" ]
140 } 140 }
141
142 # 4702 warning -----------------------------------------------------------------
143
144 # VS xtree header file needs to be patched or 4702 (unreachable code warning)
145 # is reported if _HAS_EXCEPTIONS=0. Disable the warning if xtree is not patched.
146
147 config("msvs_xtree_unreachable_code") {
148 if (!msvs_xtree_patched) {
149 cflags = [ "/wd4702" ]
150 }
151 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698