Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 965713002: Handle unpatched VS xtree header (Closed)

Created:
5 years, 9 months ago by Tomasz Moniuszko
Modified:
5 years, 9 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle unpatched VS xtree header BUG= Committed: https://crrev.com/b5020725ac56d11c064086295af7db628b4fe64b Cr-Commit-Position: refs/heads/master@{#318859} Committed: https://crrev.com/d6edee7b20e353e0943103a1e6b232f940f80c89 Cr-Commit-Position: refs/heads/master@{#319035}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Solution moved to build/config/compiler/BUILD.gn #

Total comments: 1

Patch Set 3 : Wrap msvs_xtree_patched in is_win conditional #

Patch Set 4 : Remove redundant assignment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M build/config/compiler/BUILD.gn View 1 2 3 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (4 generated)
Tomasz Moniuszko
This is gyp solution adopted to gn.
5 years, 9 months ago (2015-02-27 11:41:40 UTC) #2
brettw
https://codereview.chromium.org/965713002/diff/1/build/config/BUILDCONFIG.gn File build/config/BUILDCONFIG.gn (right): https://codereview.chromium.org/965713002/diff/1/build/config/BUILDCONFIG.gn#newcode359 build/config/BUILDCONFIG.gn:359: "//build/config/win:msvs_xtree_unreachable_code", We only need to add stuff to this ...
5 years, 9 months ago (2015-02-27 22:43:24 UTC) #3
Tomasz Moniuszko
On 2015/02/27 22:43:24, brettw wrote: > https://codereview.chromium.org/965713002/diff/1/build/config/BUILDCONFIG.gn > File build/config/BUILDCONFIG.gn (right): > > https://codereview.chromium.org/965713002/diff/1/build/config/BUILDCONFIG.gn#newcode359 > ...
5 years, 9 months ago (2015-03-02 10:43:46 UTC) #4
brettw
lgtm https://codereview.chromium.org/965713002/diff/20001/build/config/compiler/BUILD.gn File build/config/compiler/BUILD.gn (right): https://codereview.chromium.org/965713002/diff/20001/build/config/compiler/BUILD.gn#newcode55 build/config/compiler/BUILD.gn:55: msvs_xtree_patched = false Can you wrap this comment ...
5 years, 9 months ago (2015-03-02 19:14:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/965713002/40001
5 years, 9 months ago (2015-03-03 09:48:45 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-03 10:28:10 UTC) #9
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/b5020725ac56d11c064086295af7db628b4fe64b Cr-Commit-Position: refs/heads/master@{#318859}
5 years, 9 months ago (2015-03-03 10:29:00 UTC) #10
ulan
On 2015/03/03 10:29:00, I haz the power (commit-bot) wrote: > Patchset 3 (id:??) landed as ...
5 years, 9 months ago (2015-03-03 10:50:26 UTC) #11
ulan
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/972133002/ by ulan@chromium.org. ...
5 years, 9 months ago (2015-03-03 10:56:32 UTC) #12
Tomasz Moniuszko
On 2015/03/03 10:56:32, ulan wrote: > A revert of this CL (patchset #3 id:40001) has ...
5 years, 9 months ago (2015-03-03 11:30:51 UTC) #13
brettw
lgtm
5 years, 9 months ago (2015-03-03 17:25:06 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/965713002/60001
5 years, 9 months ago (2015-03-04 08:23:40 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-04 08:50:48 UTC) #17
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 08:51:56 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/d6edee7b20e353e0943103a1e6b232f940f80c89
Cr-Commit-Position: refs/heads/master@{#319035}

Powered by Google App Engine
This is Rietveld 408576698