Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 965693002: X87: Skip the mapcheck on the global object since the global proxy and cell are already checked (Closed)

Created:
5 years, 9 months ago by chunyang.dai
Modified:
5 years, 9 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Skip the mapcheck on the global object since the global proxy and cell are already checked port 6af7ca6be4cd768b3326f0b8c32d4fbc3baa20c8 (r26886) original commit message: Skip the mapcheck on the global object since the global proxy and cell are already checked (or the global object map for contextual global loads). BUG= Committed: https://crrev.com/235bf89c876addd8f4c0a782b695ca9e79948837 Cr-Commit-Position: refs/heads/master@{#26908}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M src/ic/x87/handler-compiler-x87.cc View 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL.
5 years, 9 months ago (2015-02-27 07:48:56 UTC) #2
Weiliang
lgtm
5 years, 9 months ago (2015-02-27 07:49:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/965693002/1
5 years, 9 months ago (2015-02-27 07:50:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-02-27 08:09:21 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-02-27 08:09:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/235bf89c876addd8f4c0a782b695ca9e79948837
Cr-Commit-Position: refs/heads/master@{#26908}

Powered by Google App Engine
This is Rietveld 408576698