Fix TextTrackMode test

A TextTrackMode test sets an enum to an integer value.
This is no longer supported, and was detected by turning on "invalid enum" console warnings in CL 955413002:
http://crrev.com/955413002
...by Nils (nbarth) in this comment:
http://crrev.com/955413002#msg6

This fixes the test, and adds a test that integer values are no longer supported.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191121

[Paritosh Kumar, 2015-02-27 06:57:55]

paritosh.in@samsung.com changed reviewers:
+ nbarth@chromium.org

[Paritosh Kumar, 2015-02-27 06:57:55]

Please have a look.

[Paritosh Kumar, 2015-02-27 07:02:14]

paritosh.in@samsung.com changed reviewers:
+ haraken@chromium.org, yurys@chromium.org

[jsbell, 2015-02-27 16:50:35]

jsbell@chromium.org changed reviewers:
+ jsbell@chromium.org

[jsbell, 2015-02-27 16:50:35]

drive-by...

https://codereview.chromium.org/965683002/diff/1/LayoutTests/media/track/trac...
File LayoutTests/media/track/track-mode.html (right):

https://codereview.chromium.org/965683002/diff/1/LayoutTests/media/track/trac...
LayoutTests/media/track/track-mode.html:44: consoleWrite("<b>*** Set to numeric
value (no longer supported), should return default</b>");
Missing ) inside the string

https://codereview.chromium.org/965683002/diff/1/LayoutTests/media/track/trac...
LayoutTests/media/track/track-mode.html:46: run("textTrack.mode = '" + value +
"'");
Since this is testing numeric values, this should be just:

run("textTrack.mode = 2");

(bindings will coerce it to a string anyway, but this IMHO this captures the
intent of the test more clearly)

[haraken, 2015-02-27 16:53:01]

LGTM with jsbell's comments addressed.

[jsbell, 2015-02-27 16:54:12]

https://codereview.chromium.org/965683002/diff/1/LayoutTests/media/track/trac...
File LayoutTests/media/track/track-mode.html (right):

https://codereview.chromium.org/965683002/diff/1/LayoutTests/media/track/trac...
LayoutTests/media/track/track-mode.html:44: consoleWrite("<b>*** Set to numeric
value (no longer supported), should return default</b>");
On 2015/02/27 16:50:35, jsbell wrote:
> Missing ) inside the string

Ignore this - the ) is there, it was just slightly scrolled offscreen for me. :(

Sorry for the noise!

[Nils Barth (inactive), 2015-02-27 19:34:33]

On 2015/02/27 16:53:01, haraken wrote:
> LGTM with jsbell's comments addressed.

Ditto: LGTM with 2 as numeric literal, not string.
Thanks Paritosh!

[Paritosh Kumar, 2015-03-02 04:39:35]

Thanks Nils Jsbell and haraken for reviewing this.


Updated the test with numeric value.
Please have a look.

https://codereview.chromium.org/965683002/diff/1/LayoutTests/media/track/trac...
File LayoutTests/media/track/track-mode.html (right):

https://codereview.chromium.org/965683002/diff/1/LayoutTests/media/track/trac...
LayoutTests/media/track/track-mode.html:46: run("textTrack.mode = '" + value +
"'");
On 2015/02/27 16:50:35, jsbell wrote:
> Since this is testing numeric values, this should be just:
> 
> run("textTrack.mode = 2");
> 
> (bindings will coerce it to a string anyway, but this IMHO this captures the
> intent of the test more clearly)

Done. Thanks Jsbell.

[Nils Barth (inactive), 2015-03-02 13:41:54]

LGTM, thanks!

[Paritosh Kumar, 2015-03-02 16:25:06]

The CQ bit was checked by paritosh.in@samsung.com

[Paritosh Kumar, 2015-03-02 16:25:06]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/965683002/#ps20001 (title:
" ")

[commit-bot: I haz the power, 2015-03-02 16:25:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/965683002/20001

[commit-bot: I haz the power, 2015-03-02 17:41:09]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191121