Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(977)

Issue 965653002: Fix android GN build for chromedriver test (Closed)

Created:
5 years, 9 months ago by Tima Vaisburd
Modified:
5 years, 9 months ago
Reviewers:
brettw
CC:
chromium-reviews, samuong+watch_chromium.org, stgao
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix android GN build for chromedriver test Implemented stub FindChrome() on android that does nothing and returns false. BUG=462434 Committed: https://crrev.com/04824a974ff0bc9669a5746abefe1caa26ce6be1 Cr-Commit-Position: refs/heads/master@{#318553}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Removed empty string arg to FilePath ctor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M chrome/test/chromedriver/chrome/chrome_finder.cc View 1 2 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Tima Vaisburd
This CL is intended to unblock the GN build in android waterfall (https://uberchromegw.corp.google.com/i/clank/builders/gn-release-builder-l), please review.
5 years, 9 months ago (2015-02-27 02:27:36 UTC) #2
brettw
lgtm https://codereview.chromium.org/965653002/diff/1/chrome/test/chromedriver/chrome/chrome_finder.cc File chrome/test/chromedriver/chrome/chrome_finder.cc (right): https://codereview.chromium.org/965653002/diff/1/chrome/test/chromedriver/chrome/chrome_finder.cc#newcode102 chrome/test/chromedriver/chrome/chrome_finder.cc:102: base::FilePath("") just do FilePath() what you typed will ...
5 years, 9 months ago (2015-02-27 19:23:45 UTC) #3
Tima Vaisburd
On 2015/02/27 19:23:45, brettw wrote: > lgtm > > https://codereview.chromium.org/965653002/diff/1/chrome/test/chromedriver/chrome/chrome_finder.cc > File chrome/test/chromedriver/chrome/chrome_finder.cc (right): > ...
5 years, 9 months ago (2015-02-27 23:11:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/965653002/20001
5 years, 9 months ago (2015-02-27 23:12:14 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-02-28 00:04:46 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-02-28 00:05:27 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/04824a974ff0bc9669a5746abefe1caa26ce6be1
Cr-Commit-Position: refs/heads/master@{#318553}

Powered by Google App Engine
This is Rietveld 408576698