Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 965633002: Add remoting and PPAPI tests to GN build (Closed)

Created:
5 years, 9 months ago by brettw
Modified:
5 years, 9 months ago
Reviewers:
Dirk Pranke, kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add remoting and PPAPI tests to GN build BUG= Committed: https://crrev.com/d0437210926b14b1b7e06b2b56174fc92ade9c37 Cr-Commit-Position: refs/heads/master@{#318539}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : Add PPAPI #

Patch Set 4 : chromeos fix #

Patch Set 5 : Add skia dep for chromeos #

Patch Set 6 : file lists #

Patch Set 7 : merge fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+688 lines, -111 lines) Patch
M BUILD.gn View 1 2 3 4 5 6 3 chunks +4 lines, -2 lines 0 comments Download
A build/config/linux/gtk/BUILD.gn View 1 2 3 1 chunk +42 lines, -0 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/BUILD.gn View 1 2 3 3 chunks +2 lines, -17 lines 0 comments Download
M ppapi/BUILD.gn View 2 chunks +75 lines, -1 line 0 comments Download
M ppapi/ppapi_host.gypi View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/ppapi_tests.gypi View 4 chunks +4 lines, -0 lines 0 comments Download
A remoting/BUILD.gn View 1 1 chunk +104 lines, -0 lines 0 comments Download
M remoting/base/BUILD.gn View 1 2 chunks +40 lines, -9 lines 0 comments Download
M remoting/client/BUILD.gn View 1 1 chunk +35 lines, -11 lines 0 comments Download
M remoting/client/plugin/BUILD.gn View 1 2 chunks +14 lines, -7 lines 0 comments Download
A remoting/codec/BUILD.gn View 1 1 chunk +47 lines, -0 lines 0 comments Download
M remoting/host/BUILD.gn View 1 2 3 4 3 chunks +127 lines, -10 lines 0 comments Download
M remoting/host/it2me/BUILD.gn View 1 2 chunks +10 lines, -14 lines 0 comments Download
A remoting/host/native_messaging/BUILD.gn View 1 2 3 4 5 1 chunk +19 lines, -0 lines 0 comments Download
A remoting/host/setup/BUILD.gn View 1 2 3 4 5 1 chunk +32 lines, -0 lines 0 comments Download
M remoting/protocol/BUILD.gn View 1 3 chunks +68 lines, -7 lines 0 comments Download
M remoting/remoting.gyp View 2 chunks +2 lines, -1 line 0 comments Download
M remoting/remoting_host.gypi View 1 2 3 4 5 3 chunks +4 lines, -30 lines 0 comments Download
M remoting/remoting_host_srcs.gypi View 1 2 3 4 5 1 chunk +35 lines, -1 line 0 comments Download
M remoting/remoting_nacl.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A remoting/remoting_srcs.gni View 1 1 chunk +14 lines, -0 lines 0 comments Download
M remoting/remoting_srcs.gypi View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/remoting_test.gypi View 1 2 3 4 4 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
brettw
5 years, 9 months ago (2015-02-27 18:02:53 UTC) #2
brettw
dirk: non-remoting code.
5 years, 9 months ago (2015-02-27 20:55:45 UTC) #4
kelvinp
https://codereview.chromium.org/965633002/diff/1/remoting/host/native_messaging/BUILD.gn File remoting/host/native_messaging/BUILD.gn (right): https://codereview.chromium.org/965633002/diff/1/remoting/host/native_messaging/BUILD.gn#newcode1 remoting/host/native_messaging/BUILD.gn:1: # Copyright 2015 The Chromium Authors. All rights reserved. ...
5 years, 9 months ago (2015-02-27 21:00:57 UTC) #5
brettw
File lists moved to gypi variables, PTAL.
5 years, 9 months ago (2015-02-27 21:34:44 UTC) #6
Dirk Pranke
lgtm
5 years, 9 months ago (2015-02-27 21:47:02 UTC) #7
kelvinp
lgtm
5 years, 9 months ago (2015-02-27 21:59:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/965633002/100001
5 years, 9 months ago (2015-02-27 22:04:18 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/706) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 9 months ago (2015-02-27 22:08:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/965633002/120001
5 years, 9 months ago (2015-02-27 22:11:48 UTC) #15
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 9 months ago (2015-02-27 23:24:29 UTC) #16
commit-bot: I haz the power
Patchset 7 (id:??) landed as https://crrev.com/d0437210926b14b1b7e06b2b56174fc92ade9c37 Cr-Commit-Position: refs/heads/master@{#318539}
5 years, 9 months ago (2015-02-27 23:25:22 UTC) #17
eroman
5 years, 9 months ago (2015-02-27 23:38:56 UTC) #18
Message was sent while issue was closed. 
A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/970443002/ by eroman@chromium.org.

The reason for reverting is:
http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%20GN&number=...

ERROR at //remoting/host/BUILD.gn:56:7: Item not found
      "linux/x_server_clipboard.cc",
      ^----------------------------
You were trying to remove "linux/x_server_clipboard.cc".

Powered by Google App Engine
This is Rietveld 408576698