extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.h - Issue 965613002: Open a firewall hole when a TCP server or UDP socket is bound.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.h

Issue 965613002: Open a firewall hole when a TCP server or UDP socket is bound. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address the rest of pneubeck@'s comments. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chromeos/network/firewall_hole.cc ('K') | « extensions/browser/api/socket/socket_api.cc ('k') | extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.h

diff --git a/extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.h b/extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.h

index f13f083dbc974788ecc00e630579bfaf2e854f9e..531fd2cb19ec0c9db545b65a5185b90e65e88edd 100644

--- a/extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.h

+++ b/extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.h

@@ -94,7 +94,7 @@ class SocketsTcpServerListenFunction : public TCPServerSocketAsyncApiFunction {

// AsyncApiFunction:

bool Prepare() override;

- void Work() override;

+ void AsyncWorkStart() override;

private:

scoped_ptr<sockets_tcp_server::Listen::Params> params_;