Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/OverflowSelector.java

Issue 965603002: Creates reusable button for usage in Smart Lock infobars. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/infobar/AccountChooserInfoBar.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/OverflowSelector.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/OverflowSelector.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/OverflowSelector.java
new file mode 100644
index 0000000000000000000000000000000000000000..b41d00581335246f7eb6a36d60575804bb8b8628
--- /dev/null
+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/OverflowSelector.java
@@ -0,0 +1,68 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.chrome.browser.infobar;
+
+import android.content.Context;
+import android.view.MenuItem;
+import android.view.View;
+import android.view.View.OnClickListener;
+import android.widget.Button;
+import android.widget.PopupMenu;
+import android.widget.PopupMenu.OnMenuItemClickListener;
+
+import org.chromium.chrome.R;
+import org.chromium.chrome.browser.preferences.PreferencesLauncher;
+import org.chromium.chrome.browser.widget.ButtonCompat;
+
+/**
+ * Button with text "More", which opens a popup with two elements: "Learn more" link to help center
+ * and link named "Settings" which opens general settings page. This element is used by Smart Lock
+ * infobars.
+ */
+public class OverflowSelector {
+ private OverflowSelector() {}
+
+ /**
+ * Creates a material style borderless button with text "More" which opens a popup menu,
+ * which allows to go to help center article or Settings.
+ */
+ public static Button createOverflowSelector(Context context) {
+ Button b = ButtonCompat.createBorderlessButton(context);
+ b.setText(context.getString(R.string.more));
+ b.setOnClickListener(new OnClickListener() {
+ @Override
+ public void onClick(View view) {
+ OverflowSelector.showMorePopup(view);
+ }
+ });
+ return b;
+ }
+
+ /** Pops up menu with two items: "Settings" and "Learn more" when user clicks "More" button. */
+ private static void showMorePopup(View v) {
+ final Context context = v.getContext();
+ PopupMenu popup = new PopupMenu(context, v);
+ popup.setOnMenuItemClickListener(new OnMenuItemClickListener() {
+ @Override
+ public boolean onMenuItemClick(MenuItem item) {
+ return OverflowSelector.processMenuItem(item, context);
+ }
+ });
+ popup.inflate(R.menu.overflow_selector_for_smart_lock_infobars);
+ popup.show();
+ }
+
+ private static boolean processMenuItem(MenuItem item, Context context) {
+ if (item.getItemId() == R.id.settings) {
+ // TODO(melandory) When Smart Lock setting will be implemented for Chrome on Android
+ // this code should open settings fragment with Smart Lock parameters.
+ PreferencesLauncher.launchSettingsPage(context, null);
+ return true;
+ }
+ // TODO(melandory): Learn more should open link to help center
+ // article which is not ready yet.
+ return false;
+ }
+}
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/infobar/AccountChooserInfoBar.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698