Filter out redundant jumplist updates.

chrome/browser/jumplist_win.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/jumplist_win.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/files/file_util.h"
@@ skipping 28 matching lines @@
 #include "ui/gfx/codec/png_codec.h"
 #include "ui/gfx/favicon_size.h"
 #include "ui/gfx/icon_util.h"
 #include "ui/gfx/image/image_family.h"
 #include "url/gurl.h"
 
 using content::BrowserThread;
 
 namespace {
 
+// Delay jumplist update tasks to allow collapsing of redundant
+// update requests.

[gab, 2015/06/03 19:03:50]

Looks like "update" fits on previous line.

[brucedawson, 2015/06/04 17:11:59]

Done.

+const int kDelayForJumplistUpdateInMS = 3500;
+
 // Append the common switches to each shell link.
 void AppendCommonSwitches(ShellLinkItem* shell_link) {
   const char* kSwitchNames[] = { switches::kUserDataDir };
   const base::CommandLine& command_line =
       *base::CommandLine::ForCurrentProcess();
   shell_link->GetCommandLine()->CopySwitchesFrom(command_line,
                                                  kSwitchNames,
                                                  arraysize(kSwitchNames));
 }
 
@@ skipping 374 matching lines @@
     base::AutoLock auto_lock(list_lock_);
     waiting_for_icons = !icon_urls_.empty();
   }
   if (!waiting_for_icons)
     PostRunUpdate();
   // If |icon_urls_| isn't empty then OnFaviconDataAvailable will eventually
   // call PostRunUpdate().
 }
 
 void JumpList::PostRunUpdate() {
+

[gab, 2015/06/03 19:03:50]

No empty line.

[brucedawson, 2015/06/04 17:11:59]

Done.

+  // Initialize the one-shot timer to update the jumplists in a while.
+  // If there is already a request queued then cancel it and post the new
+  // request. This ensures that JumpListUpdates won't happen until there has
+  // been a brief quiet period, thus avoiding update storms.
+  if (timer_.IsRunning())

[gab, 2015/06/03 19:03:50]

{}s everywhere since the else's body is multiline.

[brucedawson, 2015/06/04 17:11:59]

Done.

+    timer_.Reset();
+  else
+    timer_.Start(FROM_HERE,
+                 base::TimeDelta::FromMilliseconds(kDelayForJumplistUpdateInMS),
+                 this,
+                 &JumpList::DeferredRunUpdate);
+}
+
+void JumpList::DeferredRunUpdate() {
   // Check if incognito windows (or normal windows) are disabled by policy.
   IncognitoModePrefs::Availability incognito_availability =
       profile_ ? IncognitoModePrefs::GetAvailability(profile_->GetPrefs())
                : IncognitoModePrefs::ENABLED;
 
   BrowserThread::PostTask(
       BrowserThread::FILE, FROM_HERE,
       base::Bind(&JumpList::RunUpdateOnFileThread,
                  this,
                  incognito_availability));
@@ skipping 52 matching lines @@
 
 void JumpList::TopSitesLoaded(history::TopSites* top_sites) {
 }
 
 void JumpList::TopSitesChanged(history::TopSites* top_sites) {
   top_sites->GetMostVisitedURLs(
       base::Bind(&JumpList::OnMostVisitedURLsAvailable,
                  weak_ptr_factory_.GetWeakPtr()),
       false);
 }