Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 965493002: Introduce Stocks.apk (Closed)

Created:
5 years, 9 months ago by abarth-chromium
Modified:
5 years, 9 months ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, esprehn, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Introduce Stocks.apk This CL renames SkyShell.apk to SkyDemo.apk and adds a Stocks.apk which defaults to the stocks demo app. Sky Shell is now a library that can be packaged by different APKs. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/55ff7f86b1dee9726b362532adbb48ae9a825f1a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -407 lines) Patch
M sky/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
A + sky/apk/demo/AndroidManifest.xml View 1 chunk +3 lines, -3 lines 0 comments Download
A sky/apk/demo/BUILD.gn View 1 chunk +25 lines, -0 lines 0 comments Download
A + sky/apk/demo/org/domokit/sky/demo/SkyDemoActivity.java View 2 chunks +6 lines, -8 lines 0 comments Download
A sky/apk/rules.gni View 1 chunk +23 lines, -0 lines 0 comments Download
A + sky/apk/stocks/AndroidManifest.xml View 2 chunks +3 lines, -8 lines 0 comments Download
A sky/apk/stocks/BUILD.gn View 1 chunk +25 lines, -0 lines 0 comments Download
A sky/apk/stocks/org/domokit/stocks/StocksActivity.java View 1 chunk +23 lines, -0 lines 0 comments Download
M sky/shell/BUILD.gn View 4 chunks +9 lines, -39 lines 0 comments Download
D sky/shell/apk/AndroidManifest.xml View 1 chunk +0 lines, -29 lines 0 comments Download
D sky/shell/apk/res/values/strings.xml View 1 chunk +0 lines, -7 lines 0 comments Download
D sky/shell/apk/src/org/domokit/sky/shell/JavaServiceProvider.java View 1 chunk +0 lines, -53 lines 0 comments Download
D sky/shell/apk/src/org/domokit/sky/shell/PlatformView.java View 1 chunk +0 lines, -128 lines 0 comments Download
D sky/shell/apk/src/org/domokit/sky/shell/SkyMain.java View 1 chunk +0 lines, -44 lines 0 comments Download
D sky/shell/apk/src/org/domokit/sky/shell/SkyShellActivity.java View 1 chunk +0 lines, -36 lines 0 comments Download
D sky/shell/apk/src/org/domokit/sky/shell/SkyShellApplication.java View 1 chunk +0 lines, -53 lines 0 comments Download
A + sky/shell/org/domokit/sky/shell/JavaServiceProvider.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/shell/org/domokit/sky/shell/PlatformView.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A sky/shell/org/domokit/sky/shell/SkyActivity.java View 1 chunk +30 lines, -0 lines 0 comments Download
A + sky/shell/org/domokit/sky/shell/SkyApplication.java View 1 chunk +1 line, -1 line 0 comments Download
A + sky/shell/org/domokit/sky/shell/SkyMain.java View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 9 months ago (2015-02-26 19:25:38 UTC) #1
eseidel
lgtm
5 years, 9 months ago (2015-02-26 19:28:15 UTC) #2
abarth-chromium
5 years, 9 months ago (2015-02-26 20:05:23 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
55ff7f86b1dee9726b362532adbb48ae9a825f1a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698