Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 965473002: Revert of Fix CapsLock remapping. (Closed)

Created:
5 years, 10 months ago by grt (UTC plus 2)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, ozone-reviews_chromium.org, tdresser+watch_chromium.org, jdduke+watch_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix CapsLock remapping. (patchset #2 id:20001 of https://codereview.chromium.org/959923002/) Reason for revert: EventConverterEvdevImplTest.KeyWithLock failing consistently on Linux ChromiumOS Ozone Tests (1). Original issue's description: > Fix CapsLock remapping. > > Emulates the ChromeOS/X11 method of using F16 and Mod3 to > represent the caps lock key before remapping. > > BUG=461485 > TEST=On device with external keyboard > > Committed: https://crrev.com/5fdc45c765de00dd9143879864fa57c7d133e309 > Cr-Commit-Position: refs/heads/master@{#318240} TBR=spang@chromium.org,derat@chromium.org,kpschoedel@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=461485 Committed: https://crrev.com/da5a48504c87a681c6ffc27dde37960a6d505a94 Cr-Commit-Position: refs/heads/master@{#318278}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -15 lines) Patch
M ui/events/ozone/evdev/event_modifiers_evdev.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/ozone/evdev/event_modifiers_evdev.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/ozone/evdev/keyboard_evdev.cc View 2 chunks +6 lines, -9 lines 0 comments Download
M ui/events/ozone/layout/layout_util.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
grt (UTC plus 2)
Created Revert of Fix CapsLock remapping.
5 years, 10 months ago (2015-02-26 19:16:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/965473002/1
5 years, 10 months ago (2015-02-26 19:25:13 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-26 19:26:38 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 19:27:55 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da5a48504c87a681c6ffc27dde37960a6d505a94
Cr-Commit-Position: refs/heads/master@{#318278}

Powered by Google App Engine
This is Rietveld 408576698