Issue 965423002: Simplify re-throwing in RegExpExecStub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 965423002: Simplify re-throwing in RegExpExecStub. (Closed)

Created:
5 years, 9 months ago by Michael Starzinger

Modified:
5 years, 9 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@local_trycatch-8

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Simplify re-throwing in RegExpExecStub. R=yangguo@chromium.org TEST=mjsunit/regexp-stack-overflow

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -49 lines)			Patch
	M	src/ia32/code-stubs-ia32.cc	View		3 chunks	+50 lines, -49 lines	0 comments	Download

Total messages: 5 (0 generated)

Michael Starzinger

This is the proposed simplification I mentioned. Not sure whether it's worth it or not. ...

5 years, 9 months ago (2015-03-02 12:52:51 UTC) #2

Yang

On 2015/03/02 12:52:51, Michael Starzinger wrote: > This is the proposed simplification I mentioned. Not ...

5 years, 9 months ago (2015-03-02 13:18:57 UTC) #3

Michael Starzinger

Hehe, well, our test-coverage of 1 says it does. :) Joking aside, I will try ...

5 years, 9 months ago (2015-03-02 14:26:36 UTC) #4

Michael Starzinger

5 years, 9 months ago (2015-03-23 09:56:13 UTC) #5

Closing. Superseded by https://codereview.chromium.org/1012103002/