Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Unified Diff: Source/core/dom/ContextLifecycleNotifier.h

Issue 965393002: Simplify ContextLifecycleNotifier's handling of ActiveDOMObjects. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: manually count the ActiveDOMObjects instead Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/dom/ContextLifecycleNotifier.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/ContextLifecycleNotifier.h
diff --git a/Source/core/dom/ContextLifecycleNotifier.h b/Source/core/dom/ContextLifecycleNotifier.h
index 3a4c914d973973124d58621585e1faf8e4ea69fb..94b6722f86f4142d2aa394c2cfccd94deff02a30 100644
--- a/Source/core/dom/ContextLifecycleNotifier.h
+++ b/Source/core/dom/ContextLifecycleNotifier.h
@@ -29,7 +29,6 @@
#define ContextLifecycleNotifier_h
#include "platform/LifecycleNotifier.h"
-#include "wtf/HashSet.h"
namespace blink {
@@ -46,17 +45,15 @@ public:
void notifySuspendingActiveDOMObjects();
void notifyStoppingActiveDOMObjects();
- using ActiveDOMObjectSet = HashSet<ActiveDOMObject*>;
-
- const ActiveDOMObjectSet& activeDOMObjects() const { return m_activeDOMObjects; }
- bool contains(ActiveDOMObject* object) const { return m_activeDOMObjects.contains(object); }
+ unsigned activeDOMObjectCount() const;
bool hasPendingActivity() const;
protected:
explicit ContextLifecycleNotifier(ExecutionContext*);
-private:
- ActiveDOMObjectSet m_activeDOMObjects;
+#if ENABLE(ASSERT)
+ bool contains(ActiveDOMObject*) const;
+#endif
};
} // namespace blink
« no previous file with comments | « no previous file | Source/core/dom/ContextLifecycleNotifier.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698