Issue 965333002: Move RemoteMediaStreamAudioTrack to Separete Files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 965333002: Move RemoteMediaStreamAudioTrack to Separete Files

Created:
5 years, 9 months ago by zhuoyu.qian

Modified:
5 years, 9 months ago

Reviewers:
tommi (sloooow) - chröme

CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Move RemoteMediaStreamAudioTrack to Separete Files As the TODO in remote_media_stream_impl.cc by tommi@, move class RemoteMediaStreamAudioTrack to separete files. BUG= R=tommi@chromium.org

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+71 lines, -30 lines)			Patch
M	content/content_renderer.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	content/renderer/media/remote_media_stream_audio_track.h	View	1 chunk	+34 lines, -0 lines	0 comments	Download
A	content/renderer/media/remote_media_stream_audio_track.cc	View	1 chunk	+34 lines, -0 lines	0 comments	Download
M	content/renderer/media/remote_media_stream_impl.cc	View	2 chunks	+1 line, -30 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tommi (sloooow) - chröme

Thanks for doing this. I think you need to update the GN build file(s) as ...

5 years, 9 months ago (2015-03-13 21:52:03 UTC) #3

zhuoyu.qian

5 years, 9 months ago (2015-03-14 03:13:40 UTC) #4

On 2015/03/13 21:52:03, tommi wrote:
> Thanks for doing this.  I think you need to update the GN build file(s) as
well.

Hi tommi, I think it may not need to update a GN file when we change file in
content/renderer.

Expand Messages | Collapse Messages