Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 9653027: Fix ui::VKEY_HANGUL handler. (Closed)

Created:
8 years, 9 months ago by Yusuke Sato
Modified:
8 years, 9 months ago
Reviewers:
Zachary Kuznia
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Fix ui::VKEY_HANGUL handler. r122724, which ported IME shortcuts from X to Aura, had a mistake. X version: { { "mozc-hangul", "xkb:kr:kr104:kor" }, kKoreanInputMethodOrLayout, XK_Hangul, 0x0, true, }, Aura version: case ui::VKEY_HANGUL: input_method_ids_to_switch.push_back("mozc-hangul"); // no xkb:kr:kr104:kor break; This CL adds "xkb:kr:kr104:kor" to the ui::VKEY_HANGUL case. BUG=None (songsuk@c will file a bug soon) TEST=browser_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126009

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M chrome/browser/chromeos/input_method/input_method_manager.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_browsertest.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Yusuke Sato
8 years, 9 months ago (2012-03-09 10:53:32 UTC) #1
Zachary Kuznia
lgtm
8 years, 9 months ago (2012-03-09 22:26:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/9653027/1
8 years, 9 months ago (2012-03-10 00:27:23 UTC) #3
commit-bot: I haz the power
Try job failure for 9653027-1 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 9 months ago (2012-03-10 03:18:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/9653027/1
8 years, 9 months ago (2012-03-10 04:27:43 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-03-10 06:09:00 UTC) #6
Change committed as 126009

Powered by Google App Engine
This is Rietveld 408576698