Remove deprecated extension notification from theme_service

chrome/browser/themes/theme_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_THEMES_THEME_SERVICE_H_
 #define CHROME_BROWSER_THEMES_THEME_SERVICE_H_
 
 #include <map>
 #include <set>
 #include <string>
@@ skipping 43 matching lines @@
 // Sent whenever the browser theme changes.  Object => NSValue wrapping the
 // ThemeService that changed.
 extern "C" NSString* const kBrowserThemeDidChangeNotification;
 #endif  // __OBJC__
 
 class ThemeService : public base::NonThreadSafe,
                      public content::NotificationObserver,
                      public KeyedService,
                      public ui::ThemeProvider {
  public:
+  // Receive notification when extension will be installed, loaded, unloaded.
+  class ExtensionObserver {

[Lei Zhang, 2015/03/10 19:25:52]

This class needs to:

- inherit from extensions::ExtensionRegistryObserver
- be forward declared in the private section
- be defined in the .cc file as class ThemeService::ExtensionObserver

And |extension_observer_| needs to be a scoped_ptr

+   public:
+    explicit ExtensionObserver(ThemeService& service);
+    ~ExtensionObserver();
+    void OnExtensionWillBeInstalled(const extensions::Extension* extension);
+    void OnExtensionLoaded(const extensions::Extension* extension);
+    // Not be called when reason is REASON_LOCK_ALL or REASON_UPDATED.
+    void OnExtensionUnloaded(const extensions::Extension* extension);
+
+   private:
+    ThemeService& theme_service_;
+  };
+
   // Public constants used in ThemeService and its subclasses:
   static const char* kDefaultThemeID;
 
   ThemeService();
   ~ThemeService() override;
 
   virtual void Init(Profile* profile);
 
   // Returns a cross platform image for an id.
   //
@@ skipping 57 matching lines @@
 
   // Uninstall theme extensions which are no longer in use. |ignore_infobars| is
   // whether unused themes should be removed despite a theme infobar being
   // visible.
   void RemoveUnusedThemes(bool ignore_infobars);
 
   // Returns the syncable service for syncing theme. The returned service is
   // owned by |this| object.
   virtual ThemeSyncableService* GetThemeSyncableService() const;
 
+  ExtensionObserver extension_observer() const;
+
   // Save the images to be written to disk, mapping file path to id.
   typedef std::map<base::FilePath, int> ImagesDiskCache;
 
  protected:
   // Set a custom default theme instead of the normal default theme.
   virtual void SetCustomDefaultTheme(
       scoped_refptr<CustomThemeSupplier> theme_supplier);
 
   // Returns true if the ThemeService should use the system theme on startup.
   virtual bool ShouldInitWithSystemTheme() const;
@@ skipping 90 matching lines @@
   // recently installed theme extensions
   std::string installed_pending_load_id_;
 
   // The number of infobars currently displayed.
   int number_of_infobars_;
 
   content::NotificationRegistrar registrar_;
 
   scoped_ptr<ThemeSyncableService> theme_syncable_service_;
 
+  ExtensionObserver extension_observer_;
+
   base::WeakPtrFactory<ThemeService> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ThemeService);
 };
 
 #endif  // CHROME_BROWSER_THEMES_THEME_SERVICE_H_