Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(999)

Issue 965203003: Revert 187103 "Fix ignored taps in contextual search on Android" (Closed)

Created:
5 years, 9 months ago by Miyoung Shin(g)
Modified:
5 years, 9 months ago
CC:
blink-reviews, blink-reviews-events_chromium.org, dglazkov+blink, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert 187103 "Fix ignored taps in contextual search on Android" Revert 186550 "Fix the problem to keep the selection when clicking..." Revert 185410 "Make sure that selection is cleared after tapping." Revert 181959 "Fix to keep the selection of the text field in input..." Reason for revert: Cursor doesn't enter into Password field text-box on first tap on Handsets & Tablets of Android. First I revert the origin patch related to the selection, then I will check this issue. Revert 187103 : > Fix ignored taps in contextual search on Android > > We should keep the selection when tapping-press and clear > the selection state after tapping release. > Focus, mouse-down and mouse-press events are triggered on > tapping. The problem is that the selection state was > initialized after handling mouse-press event. > We should initialize it after handling mousedown event like > the formal mouse event. > > BUG=440086 > R=rbyers@chromium.org,donnd@chromium.org,yosin@chromium.org > TEST=fast/events/touch/gesture/gesture-tap-setrangetext-with-events.html Revert 186550 : > Fix the problem to keep the selection when clicking the substring out of ran > > The problem is that it's not consistent to keep the selection when clicking > substiring in/out of range. We need the additional condition missing > from http://crrev.com/507533002 > > BUG=32865, 438102 > R=yosin@chromium.org > R=rbyers@chromium.org > TEST=fast/forms/setrangetext-out-of-range.html Revert 185410 : > Make sure that selection is cleared after tapping. > > The problem is that Selection is not getting cleared > after tapping of gesture. This was affected by > https://codereview.chromium.org/507533002, > because initialization for m_selectionInitiationState was > skipped in case of gesture. > This patch makes m_selectionInitiationState be initialized > after dispatching mousedown event for gesture tapping. > > BUG=429967 > R=rbyers@chromium.org > TEST=LayoutTests/fast/events/touch/gesture/gesture-tap-reset-selection-range Revert 181959: > Fix to keep the selection of the text field in input element after setSelect > > The problem is that the selection is cleared when handling mouse release. > The selection should be kept if the selection is set by setSelectionRange du > > BUG=32865 > R=yosin@chromium.org > R=rbyers@chromium.org >TEST=LayoutTests/fast/forms/setrangetext-within-events.html BUG=457147 R=rbyers@chromium.org, yosin@chromium.org, donnd@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191215

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -242 lines) Patch
D LayoutTests/fast/events/touch/gesture/gesture-tap-reset-selection-range.html View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/fast/events/touch/gesture/gesture-tap-reset-selection-range-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/events/touch/gesture/gesture-tap-setrangetext-with-events.html View 1 chunk +0 lines, -41 lines 0 comments Download
D LayoutTests/fast/events/touch/gesture/gesture-tap-setrangetext-with-events-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/fast/forms/setrangetext-out-of-range.html View 1 chunk +0 lines, -36 lines 0 comments Download
D LayoutTests/fast/forms/setrangetext-out-of-range-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/fast/forms/setrangetext-within-events.html View 1 chunk +0 lines, -46 lines 0 comments Download
D LayoutTests/fast/forms/setrangetext-within-events-expected.txt View 1 chunk +0 lines, -33 lines 0 comments Download
M Source/core/editing/FrameSelection.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/FrameSelection.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M Source/core/page/EventHandler.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/page/EventHandler.cpp View 5 chunks +2 lines, -12 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
Miyoung Shin(g)
5 years, 9 months ago (2015-03-01 05:34:36 UTC) #1
yosin_UTC9
lgtm
5 years, 9 months ago (2015-03-02 01:03:32 UTC) #2
kerz_chromium
On 2015/03/02 01:03:32, Yosi_UTC9 wrote: > lgtm As soon as possible we need this to ...
5 years, 9 months ago (2015-03-02 19:38:31 UTC) #3
Donn Denman
On 2015/03/02 19:38:31, kerz_chromium wrote: > On 2015/03/02 01:03:32, Yosi_UTC9 wrote: > > lgtm > ...
5 years, 9 months ago (2015-03-02 19:39:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/965203003/1
5 years, 9 months ago (2015-03-03 00:36:13 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/28110)
5 years, 9 months ago (2015-03-03 01:01:12 UTC) #8
Miyoung Shin(g)
On 2015/03/03 01:01:12, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 9 months ago (2015-03-03 01:05:10 UTC) #9
Miyoung Shin(g)
On 2015/03/03 01:05:10, Miyoung Shin(g) wrote: > On 2015/03/03 01:01:12, I haz the power (commit-bot) ...
5 years, 9 months ago (2015-03-03 01:12:42 UTC) #10
Rick Byers
On 2015/03/03 01:12:42, Miyoung Shin(g) wrote: > On 2015/03/03 01:05:10, Miyoung Shin(g) wrote: > > ...
5 years, 9 months ago (2015-03-03 22:00:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/965203003/1
5 years, 9 months ago (2015-03-03 22:01:42 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 23:53:30 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191215

Powered by Google App Engine
This is Rietveld 408576698