DescriptionRevert 187103 "Fix ignored taps in contextual search on Android"
Revert 186550 "Fix the problem to keep the selection when clicking..."
Revert 185410 "Make sure that selection is cleared after tapping."
Revert 181959 "Fix to keep the selection of the text field in input..."
Reason for revert:
Cursor doesn't enter into Password field text-box on first tap
on Handsets & Tablets of Android.
First I revert the origin patch related to the selection, then
I will check this issue.
Revert 187103 :
> Fix ignored taps in contextual search on Android
>
> We should keep the selection when tapping-press and clear
> the selection state after tapping release.
> Focus, mouse-down and mouse-press events are triggered on
> tapping. The problem is that the selection state was
> initialized after handling mouse-press event.
> We should initialize it after handling mousedown event like
> the formal mouse event.
>
> BUG=440086
> R=rbyers@chromium.org,donnd@chromium.org,yosin@chromium.org
> TEST=fast/events/touch/gesture/gesture-tap-setrangetext-with-events.html
Revert 186550 :
> Fix the problem to keep the selection when clicking the substring out of ran
>
> The problem is that it's not consistent to keep the selection when clicking
> substiring in/out of range. We need the additional condition missing
> from http://crrev.com/507533002
>
> BUG=32865, 438102
> R=yosin@chromium.org
> R=rbyers@chromium.org
> TEST=fast/forms/setrangetext-out-of-range.html
Revert 185410 :
> Make sure that selection is cleared after tapping.
>
> The problem is that Selection is not getting cleared
> after tapping of gesture. This was affected by
> https://codereview.chromium.org/507533002,
> because initialization for m_selectionInitiationState was
> skipped in case of gesture.
> This patch makes m_selectionInitiationState be initialized
> after dispatching mousedown event for gesture tapping.
>
> BUG=429967
> R=rbyers@chromium.org
> TEST=LayoutTests/fast/events/touch/gesture/gesture-tap-reset-selection-range
Revert 181959:
> Fix to keep the selection of the text field in input element after setSelect
>
> The problem is that the selection is cleared when handling mouse release.
> The selection should be kept if the selection is set by setSelectionRange du
>
> BUG=32865
> R=yosin@chromium.org
> R=rbyers@chromium.org
>TEST=LayoutTests/fast/forms/setrangetext-within-events.html
BUG=457147
R=rbyers@chromium.org, yosin@chromium.org, donnd@chromium.org
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191215
Patch Set 1 #Messages
Total messages: 14 (3 generated)
|