Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 965063002: Telemtry: Add a method AddDebuggingMessage to Error. (Closed)

Created:
5 years, 9 months ago by erikchen
Modified:
5 years, 9 months ago
Reviewers:
nednguyen, dtu, sullivan
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@telemetry_make_new_exceptions3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Telemtry: Add a method AddDebuggingMessage to Error. The public method on the Error exception allows anyone with access to the exception to append debugging information. BUG=460625 Committed: https://crrev.com/c40d1cd4927c2edffda4b96ce29b3470acd43ebf Cr-Commit-Position: refs/heads/master@{#319127}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Add more information about the stack trace. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
M tools/telemetry/telemetry/core/exceptions.py View 1 1 chunk +30 lines, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
erikchen
nednguyen: Please review.
5 years, 9 months ago (2015-02-27 23:14:33 UTC) #3
nednguyen
5 years, 9 months ago (2015-03-04 00:18:59 UTC) #5
sullivan
lgtm
5 years, 9 months ago (2015-03-04 14:47:43 UTC) #6
nednguyen
https://codereview.chromium.org/965063002/diff/20001/tools/telemetry/telemetry/core/exceptions.py File tools/telemetry/telemetry/core/exceptions.py (right): https://codereview.chromium.org/965063002/diff/20001/tools/telemetry/telemetry/core/exceptions.py#newcode19 tools/telemetry/telemetry/core/exceptions.py:19: self._debugging_messages.append(msg) What missing from this is we don't know ...
5 years, 9 months ago (2015-03-04 15:53:43 UTC) #7
erikchen
https://codereview.chromium.org/965063002/diff/20001/tools/telemetry/telemetry/core/exceptions.py File tools/telemetry/telemetry/core/exceptions.py (right): https://codereview.chromium.org/965063002/diff/20001/tools/telemetry/telemetry/core/exceptions.py#newcode19 tools/telemetry/telemetry/core/exceptions.py:19: self._debugging_messages.append(msg) On 2015/03/04 15:53:43, nednguyen wrote: > What missing ...
5 years, 9 months ago (2015-03-04 19:18:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/965063002/40001
5 years, 9 months ago (2015-03-04 19:21:48 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 9 months ago (2015-03-04 21:10:14 UTC) #14
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 21:11:13 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c40d1cd4927c2edffda4b96ce29b3470acd43ebf
Cr-Commit-Position: refs/heads/master@{#319127}

Powered by Google App Engine
This is Rietveld 408576698