Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Issue 965053002: Revert of Disallow subclassing Arrays. (Closed)

Created:
5 years, 9 months ago by Dmitry Lomov (no reviews)
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Disallow subclassing Arrays. (patchset #3 id:40001 of https://codereview.chromium.org/962263002/) Reason for revert: Fails on nosnap build Original issue's description: > Disallow subclassing Arrays. > > R=rossberg@chromium.org,arv@chromium.org > BUG=v8:3930 > LOG=Y > > Committed: https://crrev.com/87f3e08e72510ee5544e82bb7ad39b2b5f001ad3 > Cr-Commit-Position: refs/heads/master@{#26925} TBR=arv@chromium.org,rossberg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3930 Committed: https://crrev.com/47b6e27317c4b28b6a58299962de0ae96dbc905d Cr-Commit-Position: refs/heads/master@{#26930}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -73 lines) Patch
M src/arm/builtins-arm.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/arm/code-stubs-arm.cc View 4 chunks +0 lines, -9 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/arm64/code-stubs-arm64.cc View 4 chunks +0 lines, -12 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 4 chunks +0 lines, -9 lines 0 comments Download
M src/messages.js View 1 chunk +1 line, -2 lines 0 comments Download
M src/mips/builtins-mips.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/mips/code-stubs-mips.cc View 4 chunks +0 lines, -8 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/mips64/code-stubs-mips64.cc View 4 chunks +0 lines, -8 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-classes.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 4 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dmitry Lomov (no reviews)
Created Revert of Disallow subclassing Arrays.
5 years, 9 months ago (2015-02-27 22:26:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/965053002/1
5 years, 9 months ago (2015-02-27 22:26:18 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-02-27 22:26:32 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-02-27 22:26:44 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/47b6e27317c4b28b6a58299962de0ae96dbc905d
Cr-Commit-Position: refs/heads/master@{#26930}

Powered by Google App Engine
This is Rietveld 408576698