Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: sky/engine/core/rendering/RenderLayer.h

Issue 965013003: Move transforms from RenderLayer to RenderBox. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/rendering/RenderBoxModelObject.cpp ('k') | sky/engine/core/rendering/RenderLayer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/rendering/RenderLayer.h
diff --git a/sky/engine/core/rendering/RenderLayer.h b/sky/engine/core/rendering/RenderLayer.h
index a0834aea8e0b25bfb0832f8f734e475a59dcc927..80a393c81d0878f0e34e5f2dcf5935769b8acd2a 100644
--- a/sky/engine/core/rendering/RenderLayer.h
+++ b/sky/engine/core/rendering/RenderLayer.h
@@ -55,12 +55,7 @@
namespace blink {
-class FilterOperations;
-class HitTestRequest;
-class HitTestResult;
-class HitTestingTransformState;
class RenderStyle;
-class TransformationMatrix;
enum BorderRadiusClippingRule { IncludeSelfForBorderRadius, DoNotIncludeSelfForBorderRadius };
enum IncludeSelfOrNot { IncludeSelf, ExcludeSelf };
@@ -103,7 +98,6 @@ public:
bool isRootLayer() const { return m_isRootLayer; }
void updateLayerPositionsAfterLayout();
- void updateTransformationMatrix();
RenderLayerStackingNode* stackingNode() { return m_stackingNode.get(); }
const RenderLayerStackingNode* stackingNode() const { return m_stackingNode.get(); }
@@ -125,19 +119,10 @@ public:
LayoutRect physicalBoundingBoxIncludingReflectionAndStackingChildren(const RenderLayer* ancestorLayer, const LayoutPoint& offsetFromRoot) const;
LayoutRect boundingBoxForCompositing(const RenderLayer* ancestorLayer = 0) const;
- // This transform has the transform-origin baked in.
- TransformationMatrix* transform() const { return m_transform.get(); }
-
- bool preserves3D() const { return renderer()->style()->transformStyle3D() == TransformStyle3DPreserve3D; }
- bool has3DTransform() const { return m_transform && !m_transform->isAffine(); }
-
bool has3DTransformedDescendant() const { return m_has3DTransformedDescendant; }
// Both updates the status, and returns true if descendants of this have 3d.
bool update3DTransformedDescendantStatus();
- // FIXME: reflections should force transform-style to be flat in the style: https://bugs.webkit.org/show_bug.cgi?id=106959
- bool shouldPreserve3D() const { return renderer()->style()->transformStyle3D() == TransformStyle3DPreserve3D; }
-
void* operator new(size_t);
// Only safe to call from RenderBox::destroyLayer()
void operator delete(void*);
@@ -154,7 +139,6 @@ public:
void clipToRect(const LayerPaintingInfo&, GraphicsContext*, const ClipRect&, BorderRadiusClippingRule = IncludeSelfForBorderRadius);
void restoreClip(GraphicsContext*, const LayoutRect& paintDirtyRect, const ClipRect&);
-private:
// Bounding box in the coordinates of this layer.
LayoutRect logicalBoundingBox() const;
@@ -165,10 +149,9 @@ private:
bool shouldBeSelfPaintingLayer() const;
- void updateTransform(const RenderStyle* oldStyle, RenderStyle* newStyle);
-
void dirty3DTransformedDescendantStatus();
+private:
LayerType m_layerType;
// Self-painting layer is an optimization where we avoid the heavy RenderLayer painting
@@ -191,8 +174,6 @@ private:
RenderLayer* m_first;
RenderLayer* m_last;
- OwnPtr<TransformationMatrix> m_transform;
-
RenderLayerClipper m_clipper; // FIXME: Lazily allocate?
OwnPtr<RenderLayerStackingNode> m_stackingNode;
};
« no previous file with comments | « sky/engine/core/rendering/RenderBoxModelObject.cpp ('k') | sky/engine/core/rendering/RenderLayer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698