Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 964993002: Fix block-for test (Closed)

Created:
5 years, 9 months ago by arv (Not doing code reviews)
Modified:
5 years, 9 months ago
Reviewers:
ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix block-for test The test didn't call the test function. BUG=v8:3932 LOG=N TBR=ulan@chromium.org Committed: https://crrev.com/4b830859b7a529fe05e8ff807e4090c616d26c94 Cr-Commit-Position: refs/heads/master@{#26927}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/mjsunit/harmony/block-for.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/964993002/1
5 years, 9 months ago (2015-02-27 20:48:18 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 9 months ago (2015-02-27 20:48:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/964993002/1
5 years, 9 months ago (2015-02-27 20:57:18 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-02-27 21:22:45 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-02-27 21:23:01 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4b830859b7a529fe05e8ff807e4090c616d26c94
Cr-Commit-Position: refs/heads/master@{#26927}

Powered by Google App Engine
This is Rietveld 408576698