Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 964983002: [NaCl SDK] ppapi_simple: Don't initialize nacl_io when running in sel_ldr (Closed)

Created:
5 years, 9 months ago by Sam Clegg
Modified:
5 years, 9 months ago
Reviewers:
binji
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] ppapi_simple: Don't initialize nacl_io when running in sel_ldr When running ppapi_simple-based application in sel_ldr we almost never want to use nacl_io so don't initialize it by default. This makes it easier for application build on ppapi_simple to run both under and Chrome and sel_ldr. Committed: https://crrev.com/918b8195c559db1316fd6b1c961324cd0a53721a Cr-Commit-Position: refs/heads/master@{#318569}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M native_client_sdk/src/libraries/ppapi_simple/ps_main.c View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Sam Clegg
5 years, 9 months ago (2015-02-27 21:24:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/964983002/1
5 years, 9 months ago (2015-02-27 23:32:38 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 9 months ago (2015-02-27 23:32:39 UTC) #6
binji
lgtm
5 years, 9 months ago (2015-02-28 00:09:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/964983002/1
5 years, 9 months ago (2015-02-28 00:28:18 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-02-28 01:54:35 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-02-28 01:55:12 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/918b8195c559db1316fd6b1c961324cd0a53721a
Cr-Commit-Position: refs/heads/master@{#318569}

Powered by Google App Engine
This is Rietveld 408576698