Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 964923003: Include -lpthread on the link line automatically only for C++ (Closed)

Created:
5 years, 9 months ago by Derek Schuff
Modified:
5 years, 9 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-clang.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Include -lpthread on the link line automatically only for C++ It's not necessary for C-only programs, only when using libc++. Use %clangxx rather than %clang in the C++ tests because just changing the language (-x c++) doesn't change the linker behavior (i.e. the CCCIsCXX() check). R=jvoung@chromium.org BUG= https://code.google.com/p/nativeclient/issues/detail?id=4088 Committed: a46d3ebfd8f295a32e2dab6241d207e04302b483

Patch Set 1 #

Total comments: 2

Patch Set 2 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -10 lines) Patch
M lib/Driver/Tools.cpp View 2 chunks +6 lines, -5 lines 0 comments Download
M test/Driver/nacl-direct.c View 1 6 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Derek Schuff
5 years, 9 months ago (2015-03-04 07:40:51 UTC) #1
jvoung (off chromium)
otherwise LGTM https://codereview.chromium.org/964923003/diff/1/test/Driver/nacl-direct.c File test/Driver/nacl-direct.c (right): https://codereview.chromium.org/964923003/diff/1/test/Driver/nacl-direct.c#newcode53 test/Driver/nacl-direct.c:53: // CHECK-ARM: "-internal-isystem" "{{.*}}/../arm-nacl/include" could CHECK-ARM-NOT: "-lpthread", ...
5 years, 9 months ago (2015-03-04 17:20:10 UTC) #2
Derek Schuff
https://codereview.chromium.org/964923003/diff/1/test/Driver/nacl-direct.c File test/Driver/nacl-direct.c (right): https://codereview.chromium.org/964923003/diff/1/test/Driver/nacl-direct.c#newcode53 test/Driver/nacl-direct.c:53: // CHECK-ARM: "-internal-isystem" "{{.*}}/../arm-nacl/include" On 2015/03/04 17:20:09, jvoung wrote: ...
5 years, 9 months ago (2015-03-04 17:39:35 UTC) #3
Derek Schuff
5 years, 9 months ago (2015-03-04 17:44:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a46d3ebfd8f295a32e2dab6241d207e04302b483 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698