Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 964913005: [Telemetry] Rename PageRun to UserStoryRun part of switching from PageTestResults to UserStoryTestR… (Closed)

Created:
5 years, 9 months ago by fmeawad
Modified:
5 years, 9 months ago
Reviewers:
eakuefner, nednguyen, dtu
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Rename PageRun to UserStoryRun part of switching from PageTestResults to UserStoryTestResults This is the first step, next will rename PageTestResult to UserStoryTestResult. BUG=442036 Committed: https://crrev.com/d4f6781b67cfdc697050bc7ab5cbed7230397514 Cr-Commit-Position: refs/heads/master@{#318737}

Patch Set 1 #

Patch Set 2 : Apply the change to the rest of telemetry #

Patch Set 3 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -133 lines) Patch
M tools/telemetry/telemetry/results/csv_pivot_table_output_formatter.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/results/gtest_progress_reporter.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/results/json_output_formatter.py View 1 1 chunk +1 line, -1 line 0 comments Download
D tools/telemetry/telemetry/results/page_run.py View 1 1 chunk +0 lines, -51 lines 0 comments Download
D tools/telemetry/telemetry/results/page_run_unittest.py View 1 1 chunk +0 lines, -65 lines 0 comments Download
M tools/telemetry/telemetry/results/page_test_results.py View 1 5 chunks +5 lines, -5 lines 0 comments Download
M tools/telemetry/telemetry/results/page_test_results_unittest.py View 1 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/results/user_story_run.py View 1 2 2 chunks +7 lines, -7 lines 0 comments Download
A tools/telemetry/telemetry/results/user_story_run_unittest.py View 1 1 chunk +74 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
fmeawad
PTAL.
5 years, 9 months ago (2015-02-28 02:28:20 UTC) #2
nednguyen
5 years, 9 months ago (2015-02-28 12:02:28 UTC) #4
nednguyen
lgtm given this is the first step
5 years, 9 months ago (2015-03-01 22:53:33 UTC) #6
dtu
lgtm slowly getting there :)
5 years, 9 months ago (2015-03-02 18:25:09 UTC) #7
eakuefner
lgtm
5 years, 9 months ago (2015-03-02 18:39:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/964913005/40001
5 years, 9 months ago (2015-03-02 18:39:55 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-02 19:46:02 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 19:46:50 UTC) #12
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/d4f6781b67cfdc697050bc7ab5cbed7230397514
Cr-Commit-Position: refs/heads/master@{#318737}

Powered by Google App Engine
This is Rietveld 408576698