Issue 9649017: Revert 125761 - Implement PPB_NetworkMonitor_Private Pepper interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9649017: Revert 125761 - Implement PPB_NetworkMonitor_Private Pepper interface. (Closed)

Created:
8 years, 9 months ago by viettrungluu

Modified:
8 years, 9 months ago

Reviewers:
Sergey Ulanov

CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 125761 - Implement PPB_NetworkMonitor_Private Pepper interface. [Broke: http://build.chromium.org/p/chromium/builders/Android%20Builder/builds/2156] The P2PSocketDispatcher::NetworkListObserver has been moved to webkit_glue:: namespace in webkit/glue/network_list_observer.h . PPB_NetworkMonitor_Private_Impl uses P2PSocketDispatcher to get notifications about network changes. BUG=114808 Review URL: http://codereview.chromium.org/9557006 TBR=sergeyu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=125766

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -450 lines)			Patch
M	chrome/test/ui/ppapi_uitest.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	content/renderer/p2p/ipc_network_manager.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/renderer/p2p/socket_dispatcher.h	View	3 chunks	+18 lines, -10 lines	0 comments	Download
M	content/renderer/p2p/socket_dispatcher.cc	View	5 chunks	+5 lines, -6 lines	0 comments	Download
M	content/renderer/pepper/pepper_plugin_delegate_impl.h	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	content/renderer/pepper/pepper_plugin_delegate_impl.cc	View	2 chunks	+0 lines, -20 lines	0 comments	Download
M	ppapi/ppapi_sources.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	ppapi/tests/test_network_monitor_private.h	View	1 chunk	+0 lines, -28 lines	0 comments	Download
D	ppapi/tests/test_network_monitor_private.cc	View	1 chunk	+0 lines, -168 lines	0 comments	Download
D	webkit/glue/network_list_observer.h	View	1 chunk	+0 lines, -33 lines	0 comments	Download
M	webkit/glue/webkit_glue.gypi	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	webkit/plugins/ppapi/mock_plugin_delegate.h	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	webkit/plugins/ppapi/mock_plugin_delegate.cc	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	webkit/plugins/ppapi/plugin_delegate.h	View	2 chunks	+0 lines, -7 lines	0 comments	Download
D	webkit/plugins/ppapi/ppb_network_monitor_private_impl.h	View	1 chunk	+0 lines, -57 lines	0 comments	Download
D	webkit/plugins/ppapi/ppb_network_monitor_private_impl.cc	View	1 chunk	+0 lines, -87 lines	0 comments	Download
M	webkit/plugins/ppapi/resource_creation_impl.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages