src/compiler/simplified-lowering.cc - Issue 964843002: [turbofan] Properly unlink dead nodes in simplified lowering.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/simplified-lowering.cc

Issue 964843002: [turbofan] Properly unlink dead nodes in simplified lowering. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/simplified-lowering.cc

diff --git a/src/compiler/simplified-lowering.cc b/src/compiler/simplified-lowering.cc

index 65e070696be3f863666e5fe0bd1363c4fa332367..b3050719883c0467bf97f8d0610e494a3142c014 100644

--- a/src/compiler/simplified-lowering.cc

+++ b/src/compiler/simplified-lowering.cc

@@ -1056,7 +1056,7 @@ class RepresentationSelector {

replacements_.push_back(node);

replacements_.push_back(replacement);

}

- // TODO(titzer) node->RemoveAllInputs(); // Node is now dead.

+ node->RemoveAllInputs(); // Node is now dead.

}

void PrintUseInfo(Node* node) {

« no previous file with comments | « no previous file | test/cctest/compiler/test-simplified-lowering.cc » ('j') | no next file with comments »