Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 964813002: X87: Only dynamically perform access checks on the receiver if it's a JSGlobalProxy. (Closed)

Created:
5 years, 10 months ago by chunyang.dai
Modified:
5 years, 10 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Only dynamically perform access checks on the receiver if it's a JSGlobalProxy. port e9cdcb71743200e7dd18b0be62f764aa53729c63 (r26875) original commit message: Only dynamically perform access checks on the receiver if it's a JSGlobalProxy. Proxies up the chain are guaranteed to provide access if we had access to the receiver, since otherwise we wouldn't have been able to compile the stub in the first place. If the security check would change, the window navigates, changing the map of the JSGlobalProxy. BUG= R=weiliang.lin@intel.com Committed: https://chromium.googlesource.com/v8/v8/+/852792048cdb457ae987fb56dd673184e7af520a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -18 lines) Patch
M src/ic/x87/handler-compiler-x87.cc View 3 chunks +12 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL.
5 years, 10 months ago (2015-02-27 07:28:22 UTC) #2
Weiliang
lgtm
5 years, 10 months ago (2015-02-27 07:28:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/964813002/1
5 years, 10 months ago (2015-02-27 07:29:09 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/852792048cdb457ae987fb56dd673184e7af520a Cr-Commit-Position: refs/heads/master@{#26905}
5 years, 10 months ago (2015-02-27 07:32:25 UTC) #6
chunyang.dai
5 years, 10 months ago (2015-02-27 07:32:31 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
852792048cdb457ae987fb56dd673184e7af520a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698