Chromium Code Reviews

Issue 964783003: Add [TypeChecking=Unrestricted] to {Transition,Wheel}EventInit (Closed)

Created:
5 years, 10 months ago by Jens Widell
Modified:
5 years, 9 months ago
Reviewers:
haraken
CC:
blink-reviews, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, vivekg_samsung, vivekg, dstockwell, Timothy Loh, Inactive, darktears, arv+blink, Steve Block, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add [TypeChecking=Unrestricted] to {Transition,Wheel}EventInit This means non-finite values for double members throw TypeError exceptions. The new behavior matches Firefox. BUG=354298 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191002

Patch Set 1 #

Patch Set 2 : fix test expectations #

Unified diffs Side-by-side diffs Stats (+125 lines, -27 lines)
M LayoutTests/fast/events/constructors/transition-event-constructor.html View 2 chunks +6 lines, -6 lines 0 comments
M LayoutTests/fast/events/constructors/transition-event-constructor-expected.txt View 2 chunks +6 lines, -6 lines 0 comments
M LayoutTests/fast/events/constructors/webkit-transition-event-constructor.html View 2 chunks +6 lines, -6 lines 0 comments
M LayoutTests/fast/events/constructors/webkit-transition-event-constructor-expected.txt View 2 chunks +6 lines, -6 lines 0 comments
M LayoutTests/fast/events/constructors/wheel-event-constructor.html View 2 chunks +32 lines, -1 line 0 comments
M LayoutTests/fast/events/constructors/wheel-event-constructor-expected.txt View 1 chunk +63 lines, -0 lines 0 comments
M Source/core/events/TransitionEventInit.idl View 1 chunk +3 lines, -1 line 0 comments
M Source/core/events/WheelEventInit.idl View 1 chunk +3 lines, -1 line 0 comments

Messages

Total messages: 14 (7 generated)
Jens Widell
PTAL
5 years, 10 months ago (2015-02-27 08:11:06 UTC) #2
haraken
LGTM
5 years, 10 months ago (2015-02-27 08:17:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/964783003/1
5 years, 10 months ago (2015-02-27 08:19:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/49243)
5 years, 10 months ago (2015-02-27 09:37:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/964783003/1
5 years, 10 months ago (2015-02-27 11:35:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/964783003/20001
5 years, 9 months ago (2015-02-27 13:36:13 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-02-27 14:46:44 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191002

Powered by Google App Engine