Issue 964743003: Revert of Remove default value for number of threads in Isolate::Init.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 964743003: Revert of Remove default value for number of threads in Isolate::Init. (Closed)

Created:
5 years, 9 months ago by Yang

Modified:
5 years, 9 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Revert of Remove default value for number of threads in Isolate::Init. (patchset #1 id:1 of https://codereview.chromium.org/978773002/) Reason for revert: build failures. Original issue's description: > Remove default value for number of threads in Isolate::Init. > > Just fixing a TODO. > > R=jochen@chromium.org > > Committed: https://crrev.com/fbcebbc5bdfd8eed82d121faf07b536eb3142fb7 > Cr-Commit-Position: refs/heads/master@{#26987} TBR=jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/6e58be468a5f56a26522af77902c5abc394f57bf Cr-Commit-Position: refs/heads/master@{#26988}

Created: 5 years, 9 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	src/isolate.cc	View		1 chunk	+9 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Yang

Created Revert of Remove default value for number of threads in Isolate::Init.

5 years, 9 months ago (2015-03-04 14:26:28 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/964743003/1

5 years, 9 months ago (2015-03-04 14:27:17 UTC) #2

commit-bot: I haz the power

5 years, 9 months ago (2015-03-04 14:27:53 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/6e58be468a5f56a26522af77902c5abc394f57bf
Cr-Commit-Position: refs/heads/master@{#26988}