Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 964723004: Some minor cleanup to RenderLayerClipper. (Closed)

Created:
5 years, 9 months ago by ojan
Modified:
5 years, 9 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Some minor cleanup to RenderLayerClipper. -Remove AbsoluteClipRects. It's never used. -Inline some static functions. In the process, noticed that the clip rects for CSS clip are broken. In theory, this patch fixes that, but I didn't test it since we probably want to just remove the feature anyways. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0a489adf989e94830aa3948dbd19eb11bfddc7a7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -43 lines) Patch
M sky/engine/core/rendering/ClipRectsCache.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerClipper.cpp View 3 chunks +20 lines, -38 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 9 months ago (2015-03-02 23:25:36 UTC) #2
ojan
5 years, 9 months ago (2015-03-02 23:26:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0a489adf989e94830aa3948dbd19eb11bfddc7a7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698