Issue 964723004: Some minor cleanup to RenderLayerClipper.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 964723004: Some minor cleanup to RenderLayerClipper. (Closed)

Created:
5 years, 9 months ago by ojan

Modified:
5 years, 9 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Some minor cleanup to RenderLayerClipper. -Remove AbsoluteClipRects. It's never used. -Inline some static functions. In the process, noticed that the clip rects for CSS clip are broken. In theory, this patch fixes that, but I didn't test it since we probably want to just remove the feature anyways. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0a489adf989e94830aa3948dbd19eb11bfddc7a7

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -43 lines)			Patch
M	sky/engine/core/rendering/ClipRectsCache.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	sky/engine/core/rendering/RenderBox.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/engine/core/rendering/RenderLayerClipper.cpp	View	3 chunks	+20 lines, -38 lines	0 comments	Download

Total messages: 3 (1 generated)

ojan

5 years, 9 months ago (2015-03-02 23:26:52 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0a489adf989e94830aa3948dbd19eb11bfddc7a7 (presubmit successful).