Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 964723003: Remove HRD butterbar (Closed)

Created:
5 years, 9 months ago by dcaiafa
Modified:
5 years, 9 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove HRD butterbar and disable HRD background service BUG=462072 Committed: https://crrev.com/bad02d28065cbabb8d79a0804343cd2af93a7a37 Cr-Commit-Position: refs/heads/master@{#318921}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -47 lines) Patch
M remoting/resources/remoting_strings.grd View 1 chunk +0 lines, -3 lines 0 comments Download
M remoting/webapp/crd/js/background.js View 1 chunk +1 line, -1 line 2 comments Download
M remoting/webapp/crd/js/butter_bar.js View 3 chunks +4 lines, -43 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
dcaiafa
5 years, 9 months ago (2015-03-02 22:32:57 UTC) #2
Jamie
lgtm https://codereview.chromium.org/964723003/diff/1/remoting/webapp/crd/js/background.js File remoting/webapp/crd/js/background.js (right): https://codereview.chromium.org/964723003/diff/1/remoting/webapp/crd/js/background.js#newcode12 remoting/webapp/crd/js/background.js:12: var ENABLE_HANGOUT_REMOTE_ASSISTANCE = false; Can you file a ...
5 years, 9 months ago (2015-03-03 00:09:02 UTC) #3
dcaiafa
https://codereview.chromium.org/964723003/diff/1/remoting/webapp/crd/js/background.js File remoting/webapp/crd/js/background.js (right): https://codereview.chromium.org/964723003/diff/1/remoting/webapp/crd/js/background.js#newcode12 remoting/webapp/crd/js/background.js:12: var ENABLE_HANGOUT_REMOTE_ASSISTANCE = false; On 2015/03/03 00:09:02, Jamie wrote: ...
5 years, 9 months ago (2015-03-03 00:58:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/964723003/1
5 years, 9 months ago (2015-03-03 00:59:23 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) Timed out ...
5 years, 9 months ago (2015-03-03 03:00:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/964723003/1
5 years, 9 months ago (2015-03-03 18:35:14 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-03 19:00:08 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 19:00:44 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/bad02d28065cbabb8d79a0804343cd2af93a7a37
Cr-Commit-Position: refs/heads/master@{#318921}

Powered by Google App Engine
This is Rietveld 408576698