Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 964643003: Autofill - Don't save a credit card locally if it's already saved in Wallet. (Closed)

Created:
5 years, 10 months ago by Evan Stade
Modified:
5 years, 9 months ago
Reviewers:
brettw
CC:
chromium-reviews, estade+watch_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Autofill - Don't save a credit card locally if it's already saved in Wallet. TODO: apply the same logic (as well as the suggestion hiding logic) to addresses BUG=459741 Committed: https://crrev.com/eeb8f30a4ea6e1adcdbafe95ef164b9c4725d7ed Cr-Commit-Position: refs/heads/master@{#318582}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -1 line) Patch
M components/autofill/core/browser/personal_data_manager.cc View 2 chunks +14 lines, -1 line 0 comments Download
M components/autofill/core/browser/personal_data_manager_unittest.cc View 1 chunk +64 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Evan Stade
5 years, 10 months ago (2015-02-26 23:03:52 UTC) #2
brettw
lgtm
5 years, 10 months ago (2015-02-26 23:14:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/964643003/1
5 years, 10 months ago (2015-02-26 23:16:20 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/28317)
5 years, 10 months ago (2015-02-27 01:41:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/964643003/1
5 years, 9 months ago (2015-02-27 23:24:20 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-02-28 02:51:57 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-02-28 02:52:40 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eeb8f30a4ea6e1adcdbafe95ef164b9c4725d7ed
Cr-Commit-Position: refs/heads/master@{#318582}

Powered by Google App Engine
This is Rietveld 408576698