Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 964613002: replace kIgnore_SkAlphaType with kUnknown_SkAlphaType (Closed)

Created:
5 years, 9 months ago by reed2
Modified:
5 years, 9 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

replace kIgnore_SkAlphaType with kUnknown_SkAlphaType BUG=skia: TBR= Committed: https://skia.googlesource.com/skia/+/1c8aeeaebce9675197be31bd769e8ffa2531bf86

Patch Set 1 #

Patch Set 2 : fix comment #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -23 lines) Patch
M include/core/SkCanvas.h View 1 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkImageInfo.h View 4 chunks +4 lines, -13 lines 0 comments Download
M src/core/SkBitmap.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkBitmapDevice.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkConfig8888.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkImageInfo.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/utils/mac/SkCreateCGImageRef.cpp View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/964613002/20001
5 years, 9 months ago (2015-02-26 21:17:01 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-02-26 21:17:02 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot/builds/2354) Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, ...
5 years, 9 months ago (2015-02-26 21:18:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/964613002/40001
5 years, 9 months ago (2015-02-26 21:21:01 UTC) #7
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-02-26 21:21:01 UTC) #8
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
5 years, 9 months ago (2015-02-27 03:21:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/964613002/40001
5 years, 9 months ago (2015-02-27 14:00:22 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/1c8aeeaebce9675197be31bd769e8ffa2531bf86
5 years, 9 months ago (2015-02-27 14:00:40 UTC) #13
scroggo
5 years, 9 months ago (2015-02-27 14:21:46 UTC) #14
Message was sent while issue was closed. 
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/966753002/ by scroggo@google.com.

The reason for reverting is: This breaks Android framework build. See

https://android-build.storage.googleapis.com/builds/git_master-skia-linux-vol...

We need to stop them from using kIgnore before we can reland this..

Powered by Google App Engine
This is Rietveld 408576698