chrome/renderer/chrome_render_process_observer.cc - Issue 964583002: Remove showModalDialog (Chrome side)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/chrome_render_process_observer.cc

Issue 964583002: Remove showModalDialog (Chrome side) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/chrome_render_process_observer.cc

diff --git a/chrome/renderer/chrome_render_process_observer.cc b/chrome/renderer/chrome_render_process_observer.cc

index 09873795021c8421cacfc1c453c45bb61c30b484..c1c97c6dc8eb5abc7fe8112c89a8d1e509daf1e8 100644

--- a/chrome/renderer/chrome_render_process_observer.cc

+++ b/chrome/renderer/chrome_render_process_observer.cc

@@ -219,9 +219,6 @@ ChromeRenderProcessObserver::ChromeRenderProcessObserver(

WebRuntimeFeatures::enableRequestAutocomplete(true);

#endif

- if (command_line.HasSwitch(switches::kEnableShowModalDialog))

- WebRuntimeFeatures::enableShowModalDialog(true);

if (command_line.HasSwitch(switches::kDisableJavaScriptHarmonyShipping)) {

std::string flag("--noharmony-shipping");

v8::V8::SetFlagsFromString(flag.c_str(), static_cast<int>(flag.size()));