Remove showModalDialog (Chrome side)

Remove showModalDialog (Chrome side)

Also unhook the enterprise policy

BUG=345831
R=jam@chromium.org,atwilson@chromium.org

Committed: https://crrev.com/9486224328b4b45bd06d85459d080982167a9659
Cr-Commit-Position: refs/heads/master@{#318465}

[jam, 2015-02-26 21:40:36]

https://codereview.chromium.org/964583002/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/render_view_host_impl.cc (left):

https://codereview.chromium.org/964583002/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/render_view_host_impl.cc:917: // We can't release
the SessionStorageNamespace until our peer
why remove this code?

https://codereview.chromium.org/964583002/diff/1/content/renderer/render_view...
File content/renderer/render_view_impl.cc (right):

https://codereview.chromium.org/964583002/diff/1/content/renderer/render_view...
content/renderer/render_view_impl.cc:1505: // TODO(jochen): Now that we no
longer support showModalDialog, see if we can
there are still other callers of this, so there's nothing to do to simplify
things here afaik

[jochen (gone - plz use gerrit), 2015-02-27 07:31:28]

On 2015/02/26 at 21:40:36, jam wrote:
>
https://codereview.chromium.org/964583002/diff/1/content/browser/renderer_hos...
> File content/browser/renderer_host/render_view_host_impl.cc (left):
> 
>
https://codereview.chromium.org/964583002/diff/1/content/browser/renderer_hos...
> content/browser/renderer_host/render_view_host_impl.cc:917: // We can't
release the SessionStorageNamespace until our peer
> why remove this code?

Oops. Added back in.

> 
>
https://codereview.chromium.org/964583002/diff/1/content/renderer/render_view...
> File content/renderer/render_view_impl.cc (right):
> 
>
https://codereview.chromium.org/964583002/diff/1/content/renderer/render_view...
> content/renderer/render_view_impl.cc:1505: // TODO(jochen): Now that we no
longer support showModalDialog, see if we can
> there are still other callers of this, so there's nothing to do to simplify
things here afaik

removed.

[jochen (gone - plz use gerrit), 2015-02-27 07:31:44]

jochen@chromium.org changed reviewers:
+ mkwst@chromium.org

[jochen (gone - plz use gerrit), 2015-02-27 07:31:45]

+mkwst for deletion of IPC

[jochen (gone - plz use gerrit), 2015-02-27 07:31:58]

Drew, can you look at the policy changes please?

[Mike West, 2015-02-27 08:42:22]

IPC LGTM.

[Andrew T Wilson (Slow), 2015-02-27 09:45:36]

LGTM if you revert your change to policy_templates.json

https://codereview.chromium.org/964583002/diff/20001/components/policy/resour...
File components/policy/resources/policy_templates.json (right):

https://codereview.chromium.org/964583002/diff/20001/components/policy/resour...
components/policy/resources/policy_templates.json:6939: 'supported_on':
['chrome.*:37-42', 'chrome_os:37-42', 'android:37-42'],
I actually think this is incorrect - what you are saying here is that
EnableDeprecatedWebPlatformFeatures is only supported up to chrome 42, but the
policy itself is supported, just not the ShowModalDialog item.

I'd actually just leave this file unchanged. It's OK - at some future point we
can remove the mention of ShowModalDialog, but I think we need to have *some*
values in the 'items' attribute above, so for now just leave it here.

[jochen (gone - plz use gerrit), 2015-02-27 09:48:27]

done

[jam, 2015-02-27 16:24:21]

lgtm

[jochen (gone - plz use gerrit), 2015-02-27 16:35:25]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2015-02-27 16:35:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
atwilson@chromium.org, mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/964583002/#ps40001 (title:
"updates")

[commit-bot: I haz the power, 2015-02-27 16:37:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/964583002/40001

[commit-bot: I haz the power, 2015-02-27 16:41:34]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-27 16:42:19]

Patchset 3 (id:??) landed as
https://crrev.com/9486224328b4b45bd06d85459d080982167a9659
Cr-Commit-Position: refs/heads/master@{#318465}