components/signin/core/browser/account_tracker_service.cc - Issue 964563002: Replace SetAuthenticatedUsername with SetAuthenticatedAccountId.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/signin/core/browser/account_tracker_service.cc

Issue 964563002: Replace SetAuthenticatedUsername with SetAuthenticatedAccountId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@priv

Patch Set: rebased Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/options/options_ui_browsertest.cc ('K') | « components/signin/core/browser/account_tracker_service.h ('k') | components/signin/core/browser/signin_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/signin/core/browser/account_tracker_service.cc

diff --git a/components/signin/core/browser/account_tracker_service.cc b/components/signin/core/browser/account_tracker_service.cc

index 1191a96651ed11dc9078dce7aa27685e47bdf81a..78d942afff1d3f91b45477090ae290e8cc549cce 100644

--- a/components/signin/core/browser/account_tracker_service.cc

+++ b/components/signin/core/browser/account_tracker_service.cc

@@ -601,12 +601,8 @@ std::string AccountTrackerService::PickAccountIdForAccount(

}

-void AccountTrackerService::SeedAccountInfo(const std::string& gaia,

- const std::string& email) {

- DVLOG(1) << "AccountTrackerService::SeedAccountInfo"

- << " gaia_id=" << gaia

- << " email=" << email;

+std::string AccountTrackerService::SeedAccountInfo(const std::string& gaia,

+ const std::string& email) {

DCHECK(!gaia.empty());

DCHECK(!email.empty());

const std::string account_id = PickAccountIdForAccount(gaia, email);

@@ -617,4 +613,11 @@ void AccountTrackerService::SeedAccountInfo(const std::string& gaia,

state.info.gaia = gaia;

state.info.email = email;

SaveToPrefs(state);

+ DVLOG(1) << "AccountTrackerService::SeedAccountInfo"

+ << " account_id=" << account_id

+ << " gaia_id=" << gaia

+ << " email=" << email;

+ return account_id;

}