chrome/browser/app_controller_mac_unittest.mm - Issue 964563002: Replace SetAuthenticatedUsername with SetAuthenticatedAccountId.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/app_controller_mac_unittest.mm

Issue 964563002: Replace SetAuthenticatedUsername with SetAuthenticatedAccountId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@priv

Patch Set: rebased Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/sync_shell/javatests/src/chromium/chrome/browser/sync/SyncTest.java ('k') | chrome/browser/autocomplete/search_provider_unittest.cc » ('j') | chrome/browser/ui/webui/options/options_ui_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/app_controller_mac_unittest.mm

diff --git a/chrome/browser/app_controller_mac_unittest.mm b/chrome/browser/app_controller_mac_unittest.mm

index 5994196a135be63fdfc0ad0831d817670d71b171..a0de9d4e3be69e52f86eaf1fe24adb92d64c42d1 100644

--- a/chrome/browser/app_controller_mac_unittest.mm

+++ b/chrome/browser/app_controller_mac_unittest.mm

@@ -124,7 +124,7 @@ TEST_F(AppControllerTest, TestSigninMenuItemNoErrors) {

NSString* alreadySignedIn = l10n_util::GetNSStringFWithFixup(

IDS_SYNC_MENU_SYNCED_LABEL, base::UTF8ToUTF16(username));

SigninManager* signin = SigninManagerFactory::GetForProfile(profile_);

- signin->SetAuthenticatedUsername(username);

+ signin->SetAuthenticatedAccountInfo(username, username);

ProfileSyncService* sync = ProfileSyncServiceFactory::GetForProfile(profile_);

sync->SetSyncSetupCompleted();

[AppController updateSigninItem:syncMenuItem

@@ -144,7 +144,7 @@ TEST_F(AppControllerTest, TestSigninMenuItemAuthError) {

// Now sign in.

std::string username = "foo@example.com";

SigninManager* signin = SigninManagerFactory::GetForProfile(profile_);

- signin->SetAuthenticatedUsername(username);

+ signin->SetAuthenticatedAccountInfo(username, username);

ProfileSyncService* sync = ProfileSyncServiceFactory::GetForProfile(profile_);

sync->SetSyncSetupCompleted();

// Force an auth error.