chrome/browser/prefs/chrome_pref_service_factory.cc - Issue 964563002: Replace SetAuthenticatedUsername with SetAuthenticatedAccountId.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prefs/chrome_pref_service_factory.cc

Issue 964563002: Replace SetAuthenticatedUsername with SetAuthenticatedAccountId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@priv

Patch Set: rebased Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc ('k') | chrome/browser/profiles/gaia_info_update_service_unittest.cc » ('j') | chrome/browser/signin/signin_names_io_thread_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/prefs/chrome_pref_service_factory.cc

diff --git a/chrome/browser/prefs/chrome_pref_service_factory.cc b/chrome/browser/prefs/chrome_pref_service_factory.cc

index 3581fe1134e670e4b05a51b8300d77385000a18f..2f288a0725166b1173d1a2887b142a83e435f42e 100644

--- a/chrome/browser/prefs/chrome_pref_service_factory.cc

+++ b/chrome/browser/prefs/chrome_pref_service_factory.cc

@@ -221,6 +221,8 @@ const PrefHashFilter::TrackedPreferenceMetadata kTrackedPrefs[] = {

PrefHashFilter::VALUE_IMPERSONAL

#endif

+ // This pref is deprecated and will be removed a few releases after M43.

+ // kGoogleServicesAccountId replaces it.

{

21, prefs::kGoogleServicesUsername,

PrefHashFilter::ENFORCE_ON_LOAD,

@@ -235,6 +237,18 @@ const PrefHashFilter::TrackedPreferenceMetadata kTrackedPrefs[] = {

PrefHashFilter::VALUE_IMPERSONAL

#endif

+ {

+ 23, prefs::kGoogleServicesAccountId,

+ PrefHashFilter::ENFORCE_ON_LOAD,

+ PrefHashFilter::TRACKING_STRATEGY_ATOMIC,

+ PrefHashFilter::VALUE_PERSONAL

+ },

+ {

+ 24, prefs::kGoogleServicesLastAccountId,

+ PrefHashFilter::ENFORCE_ON_LOAD,

+ PrefHashFilter::TRACKING_STRATEGY_ATOMIC,

+ PrefHashFilter::VALUE_PERSONAL

+ },

// See note at top, new items added here also need to be added to

// histograms.xml's TrackedPreference enum.

};