Replace SetAuthenticatedUsername with SetAuthenticatedAccountId.

chromeos/login/auth/stub_authenticator.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/login/auth/stub_authenticator.h"
 
 #include "base/bind.h"
 #include "base/location.h"
 #include "base/logging.h"
 
@@ skipping 17 matching lines @@
                                       const UserContext& user_context) {
   authentication_context_ = context;
   if (expected_user_context_ != user_context)
     NOTREACHED();
   OnAuthSuccess();
 }
 
 void StubAuthenticator::AuthenticateToLogin(content::BrowserContext* context,
                                             const UserContext& user_context) {
   authentication_context_ = context;
-  if (user_context == expected_user_context_) {
+  // Don't compare the entire |expected_user_context_| to |user_context| because
+  // during non-online re-auth |user_context| does not have a gaia id.
+  if (expected_user_context_.GetUserID() == user_context.GetUserID()) {

[xiyuan, 2015/04/09 20:59:21]

Think we should also check key here because there are test(s) on top of wrong
password case (e.g. ScreenLockerTest.TestBasic).

*expected_user_context_.GetKey() == *user_context.GetKey()

[xiyuan, 2015/04/09 21:02:12]

Interesting that ScreenLockerTest.TestBasic passes on the trybots. I am puzzled
now. :(

[Roger Tawa OOO till Jul 10th, 2015/04/10 01:52:57]

Done.  But you are correct that the test passes with and without this change. 
Maybe you can open a bug to take a look at this test?

[Roger Tawa OOO till Jul 10th, 2015/04/10 01:52:57]

Done.

[xiyuan, 2015/04/10 02:50:45]

Filed http://crbug.com/475777 to track.

     message_loop_->PostTask(
         FROM_HERE, base::Bind(&StubAuthenticator::OnAuthSuccess, this));
     return;
   }
   GoogleServiceAuthError error(
       GoogleServiceAuthError::INVALID_GAIA_CREDENTIALS);
   message_loop_->PostTask(
       FROM_HERE, base::Bind(&StubAuthenticator::OnAuthFailure, this,
                             AuthFailure::FromNetworkAuthFailure(error)));
 }
@@ skipping 50 matching lines @@
 
 void StubAuthenticator::SetExpectedCredentials(
     const UserContext& user_context) {
   expected_user_context_ = user_context;
 }
 
 StubAuthenticator::~StubAuthenticator() {
 }
 
 }  // namespace chromeos