Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: chrome/browser/signin/signin_tracker_unittest.cc

Issue 964563002: Replace SetAuthenticatedUsername with SetAuthenticatedAccountId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@priv
Patch Set: rebased Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/signin/core/browser/signin_tracker.h" 5 #include "components/signin/core/browser/signin_tracker.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "chrome/browser/chrome_notification_types.h" 10 #include "chrome/browser/chrome_notification_types.h"
11 #include "chrome/browser/profiles/profile.h" 11 #include "chrome/browser/profiles/profile.h"
12 #include "chrome/browser/signin/account_tracker_service_factory.h"
12 #include "chrome/browser/signin/fake_profile_oauth2_token_service.h" 13 #include "chrome/browser/signin/fake_profile_oauth2_token_service.h"
13 #include "chrome/browser/signin/fake_profile_oauth2_token_service_builder.h" 14 #include "chrome/browser/signin/fake_profile_oauth2_token_service_builder.h"
14 #include "chrome/browser/signin/fake_signin_manager.h" 15 #include "chrome/browser/signin/fake_signin_manager.h"
15 #include "chrome/browser/signin/profile_oauth2_token_service_factory.h" 16 #include "chrome/browser/signin/profile_oauth2_token_service_factory.h"
16 #include "chrome/browser/signin/signin_manager_factory.h" 17 #include "chrome/browser/signin/signin_manager_factory.h"
17 #include "chrome/browser/signin/signin_tracker_factory.h" 18 #include "chrome/browser/signin/signin_tracker_factory.h"
18 #include "chrome/browser/sync/profile_sync_service_factory.h" 19 #include "chrome/browser/sync/profile_sync_service_factory.h"
19 #include "chrome/browser/sync/profile_sync_service_mock.h" 20 #include "chrome/browser/sync/profile_sync_service_mock.h"
20 #include "chrome/test/base/testing_profile.h" 21 #include "chrome/test/base/testing_profile.h"
22 #include "components/signin/core/browser/account_tracker_service.h"
21 #include "components/signin/core/browser/fake_auth_status_provider.h" 23 #include "components/signin/core/browser/fake_auth_status_provider.h"
22 #include "components/signin/core/browser/profile_oauth2_token_service.h" 24 #include "components/signin/core/browser/profile_oauth2_token_service.h"
23 #include "components/signin/core/browser/signin_manager.h" 25 #include "components/signin/core/browser/signin_manager.h"
24 #include "content/public/test/test_browser_thread_bundle.h" 26 #include "content/public/test/test_browser_thread_bundle.h"
25 #include "google_apis/gaia/gaia_constants.h" 27 #include "google_apis/gaia/gaia_constants.h"
26 #include "google_apis/gaia/google_service_auth_error.h" 28 #include "google_apis/gaia/google_service_auth_error.h"
27 29
28 #include "testing/gmock/include/gmock/gmock.h" 30 #include "testing/gmock/include/gmock/gmock.h"
29 #include "testing/gtest/include/gtest/gtest.h" 31 #include "testing/gtest/include/gtest/gtest.h"
30 32
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 fake_oauth2_token_service_ = 64 fake_oauth2_token_service_ =
63 static_cast<FakeProfileOAuth2TokenService*>( 65 static_cast<FakeProfileOAuth2TokenService*>(
64 ProfileOAuth2TokenServiceFactory::GetForProfile(profile_.get())); 66 ProfileOAuth2TokenServiceFactory::GetForProfile(profile_.get()));
65 67
66 mock_signin_manager_ = static_cast<FakeSigninManagerForTesting*>( 68 mock_signin_manager_ = static_cast<FakeSigninManagerForTesting*>(
67 SigninManagerFactory::GetForProfile(profile_.get())); 69 SigninManagerFactory::GetForProfile(profile_.get()));
68 70
69 tracker_ = 71 tracker_ =
70 SigninTrackerFactory::CreateForProfile(profile_.get(), &observer_); 72 SigninTrackerFactory::CreateForProfile(profile_.get(), &observer_);
71 } 73 }
74
72 void TearDown() override { 75 void TearDown() override {
73 tracker_.reset(); 76 tracker_.reset();
74 profile_.reset(); 77 profile_.reset();
75 } 78 }
76 79
80 // Seed the account tracker with information from logged in user. Normally
81 // this is done by UI code before calling SigninManager. Returns the string
82 // to use as the account_id.
83 std::string AddToAccountTracker(const std::string& gaia_id,
84 const std::string& email) {
85 AccountTrackerService* service =
86 AccountTrackerServiceFactory::GetForProfile(profile_.get());
87 service->SeedAccountInfo(gaia_id, email);
Mike Lerman 2015/04/08 14:45:26 You can just return the result of SeedAccountInfo
Roger Tawa OOO till Jul 10th 2015/04/08 20:24:20 Removed function, not needed.
88 return service->PickAccountIdForAccount(gaia_id, email);
89 }
90
77 content::TestBrowserThreadBundle thread_bundle_; 91 content::TestBrowserThreadBundle thread_bundle_;
78 scoped_ptr<SigninTracker> tracker_; 92 scoped_ptr<SigninTracker> tracker_;
79 scoped_ptr<TestingProfile> profile_; 93 scoped_ptr<TestingProfile> profile_;
80 FakeSigninManagerForTesting* mock_signin_manager_; 94 FakeSigninManagerForTesting* mock_signin_manager_;
81 FakeProfileOAuth2TokenService* fake_oauth2_token_service_; 95 FakeProfileOAuth2TokenService* fake_oauth2_token_service_;
82 MockObserver observer_; 96 MockObserver observer_;
83 }; 97 };
84 98
85 #if !defined(OS_CHROMEOS) 99 #if !defined(OS_CHROMEOS)
86 TEST_F(SigninTrackerTest, SignInFails) { 100 TEST_F(SigninTrackerTest, SignInFails) {
87 const GoogleServiceAuthError error( 101 const GoogleServiceAuthError error(
88 GoogleServiceAuthError::INVALID_GAIA_CREDENTIALS); 102 GoogleServiceAuthError::INVALID_GAIA_CREDENTIALS);
89 103
90 // Signin failure should result in a SigninFailed callback. 104 // Signin failure should result in a SigninFailed callback.
91 EXPECT_CALL(observer_, SigninSuccess()).Times(0); 105 EXPECT_CALL(observer_, SigninSuccess()).Times(0);
92 EXPECT_CALL(observer_, SigninFailed(error)); 106 EXPECT_CALL(observer_, SigninFailed(error));
93 107
94 mock_signin_manager_->FailSignin(error); 108 mock_signin_manager_->FailSignin(error);
95 } 109 }
96 #endif // !defined(OS_CHROMEOS) 110 #endif // !defined(OS_CHROMEOS)
97 111
98 TEST_F(SigninTrackerTest, SignInSucceeds) { 112 TEST_F(SigninTrackerTest, SignInSucceeds) {
99 EXPECT_CALL(observer_, SigninSuccess()); 113 EXPECT_CALL(observer_, SigninSuccess());
100 EXPECT_CALL(observer_, SigninFailed(_)).Times(0); 114 EXPECT_CALL(observer_, SigninFailed(_)).Times(0);
101 115
102 mock_signin_manager_->SetAuthenticatedUsername("user@gmail.com"); 116 std::string account_id = AddToAccountTracker("gaia_id", "user@gmail.com");
103 fake_oauth2_token_service_->IssueRefreshTokenForUser( 117 mock_signin_manager_->SetAuthenticatedAccountInfo("gaia_id",
104 "user@gmail.com", "refresh_token"); 118 "user@gmail.com");
119 fake_oauth2_token_service_->IssueRefreshTokenForUser(account_id,
120 "refresh_token");
105 } 121 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698